Issue 14119008: ARM: VFP cleanup now that VFP2 is the baseline.

Issue 14119008: ARM: VFP cleanup now that VFP2 is the baseline. (Closed)

Created:
7 years, 8 months ago by Rodolph Perfetta

Modified:
7 years, 8 months ago

Reviewers:
ulan, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ARM: VFP cleanup now that VFP2 is the baseline. BUG=none TEST=none Committed: https://code.google.com/p/v8/source/detail?r=14382

Patch Set 1 #

Total comments: 12

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+305 lines, -772 lines)			Patch
M	src/arm/code-stubs-arm.h	View	1 chunk	+0 lines, -136 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	11 chunks	+89 lines, -475 lines	6 comments	Download
M	src/arm/ic-arm.cc	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	6 chunks	+56 lines, -35 lines	6 comments	Download
M	src/arm/macro-assembler-arm.cc	View	10 chunks	+146 lines, -81 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	7 chunks	+9 lines, -34 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM with nits. https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc#newcode1896 src/arm/code-stubs-arm.cc:1896: // Load left and right operands ...

7 years, 8 months ago (2013-04-22 11:24:49 UTC) #2

Rodolph Perfetta

7 years, 8 months ago (2013-04-22 21:30:33 UTC) #3

https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc#new...
src/arm/code-stubs-arm.cc:1896: // Load left and right operands into d6 and d7.
On 2013/04/22 11:24:49, ulan wrote:
> Load left and right operands into d0 and d1.

Done.

https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc#new...
src/arm/code-stubs-arm.cc:1898: __ SmiUntag(scratch1, r0);
On 2013/04/22 11:24:49, ulan wrote:
> We can use left and right instead of r1 and r0.

Done.

https://codereview.chromium.org/14119008/diff/1/src/arm/code-stubs-arm.cc#new...
src/arm/code-stubs-arm.cc:1905: // Load right operand to d7 or r2/r3.
On 2013/04/22 11:24:49, ulan wrote:
> Obsolete comments here and below.

Done.

https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):

https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h...
src/arm/macro-assembler-arm.h:498: // Convert the smi or heap number in object
to an int32 using the rules
On 2013/04/22 11:24:49, ulan wrote:
> "Converts"

Done.

https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h...
src/arm/macro-assembler-arm.h:512: // The value ends up either in |dst|.
On 2013/04/22 11:24:49, ulan wrote:
> "Loads the number from object into dst register."

Done.

https://codereview.chromium.org/14119008/diff/1/src/arm/macro-assembler-arm.h...
src/arm/macro-assembler-arm.h:521: // Load the number from object into
double_dst in the double format.
On 2013/04/22 11:24:49, ulan wrote:
> "Loads"

Done.

Expand Messages | Collapse Messages