Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Side by Side Diff: chrome/browser/ui/views/toolbar/toolbar_button.h

Issue 1411833006: Refactoring to make adding ink drop animations easier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactor ink drop animations (nits in ui/views/ Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_TOOLBAR_TOOLBAR_BUTTON_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_TOOLBAR_TOOLBAR_BUTTON_H_
6 #define CHROME_BROWSER_UI_VIEWS_TOOLBAR_TOOLBAR_BUTTON_H_ 6 #define CHROME_BROWSER_UI_VIEWS_TOOLBAR_TOOLBAR_BUTTON_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "ui/gfx/geometry/point.h" 9 #include "ui/gfx/geometry/point.h"
10 #include "ui/views/animation/ink_drop_host.h" 10 #include "ui/views/animation/ink_drop_host.h"
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 // views::LabelButton: 66 // views::LabelButton:
67 bool ShouldEnterPushedState(const ui::Event& event) override; 67 bool ShouldEnterPushedState(const ui::Event& event) override;
68 void NotifyClick(const ui::Event& event) override; 68 void NotifyClick(const ui::Event& event) override;
69 69
70 // Returns if menu should be shown. Override this to change default behavior. 70 // Returns if menu should be shown. Override this to change default behavior.
71 virtual bool ShouldShowMenu(); 71 virtual bool ShouldShowMenu();
72 72
73 // Function to show the dropdown menu. 73 // Function to show the dropdown menu.
74 virtual void ShowDropDownMenu(ui::MenuSourceType source_type); 74 virtual void ShowDropDownMenu(ui::MenuSourceType source_type);
75 75
76 // Returns the Point where the ink drop should be centered.
77 virtual gfx::Point CalculateInkDropCenter() const;
78
79 views::InkDropAnimationController* ink_drop_animation_controller() { 76 views::InkDropAnimationController* ink_drop_animation_controller() {
80 return ink_drop_animation_controller_.get(); 77 return ink_drop_animation_controller_.get();
81 } 78 }
82 79
83 private: 80 private:
84 // views::LabelButton: 81 // views::LabelButton:
85 const char* GetClassName() const override; 82 const char* GetClassName() const override;
86 83
84 // views::InkDropHost:
85 gfx::Point CalculateInkDropCenter() const override;
86
87 // The model that populates the attached menu. 87 // The model that populates the attached menu.
88 scoped_ptr<ui::MenuModel> model_; 88 scoped_ptr<ui::MenuModel> model_;
89 89
90 // Indicates if menu is currently showing. 90 // Indicates if menu is currently showing.
91 bool menu_showing_; 91 bool menu_showing_;
92 92
93 // Y position of mouse when left mouse button is pressed 93 // Y position of mouse when left mouse button is pressed
94 int y_position_on_lbuttondown_; 94 int y_position_on_lbuttondown_;
95 95
96 // Menu runner to display drop down menu. 96 // Menu runner to display drop down menu.
97 scoped_ptr<views::MenuRunner> menu_runner_; 97 scoped_ptr<views::MenuRunner> menu_runner_;
98 98
99 // Animation controller for the ink drop ripple effect. 99 // Animation controller for the ink drop ripple effect.
100 scoped_ptr<views::InkDropAnimationController> ink_drop_animation_controller_; 100 scoped_ptr<views::InkDropAnimationController> ink_drop_animation_controller_;
101 101
102 // A factory for tasks that show the dropdown context menu for the button. 102 // A factory for tasks that show the dropdown context menu for the button.
103 base::WeakPtrFactory<ToolbarButton> show_menu_factory_; 103 base::WeakPtrFactory<ToolbarButton> show_menu_factory_;
104 104
105 DISALLOW_COPY_AND_ASSIGN(ToolbarButton); 105 DISALLOW_COPY_AND_ASSIGN(ToolbarButton);
106 }; 106 };
107 107
108 #endif // CHROME_BROWSER_UI_VIEWS_TOOLBAR_TOOLBAR_BUTTON_H_ 108 #endif // CHROME_BROWSER_UI_VIEWS_TOOLBAR_TOOLBAR_BUTTON_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_action_view.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698