Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 14118014: Android: extracts "repo_utils.py" from flakiness_dashboard_results_uploader.py. (Closed)

Created:
7 years, 8 months ago by bulach
Modified:
7 years, 8 months ago
Reviewers:
frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Android: extracts "repo_utils.py" from flakiness_dashboard_results_uploader.py. Small reusable module. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196112

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove \n #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M build/android/pylib/utils/flakiness_dashboard_results_uploader.py View 1 2 chunks +2 lines, -11 lines 0 comments Download
A build/android/pylib/utils/repo_utils.py View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bulach
ptal
7 years, 8 months ago (2013-04-23 18:46:25 UTC) #1
frankf
Thanks Marcus! lgtm https://codereview.chromium.org/14118014/diff/1/build/android/pylib/utils/flakiness_dashboard_results_uploader.py File build/android/pylib/utils/flakiness_dashboard_results_uploader.py (right): https://codereview.chromium.org/14118014/diff/1/build/android/pylib/utils/flakiness_dashboard_results_uploader.py#newcode35 build/android/pylib/utils/flakiness_dashboard_results_uploader.py:35: no blank line
7 years, 8 months ago (2013-04-23 19:06:47 UTC) #2
bulach
thanks! CQing.
7 years, 8 months ago (2013-04-23 19:26:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/14118014/2003
7 years, 8 months ago (2013-04-23 19:26:59 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=138608
7 years, 8 months ago (2013-04-23 23:24:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/14118014/2003
7 years, 8 months ago (2013-04-24 07:55:15 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-24 10:31:34 UTC) #7
Message was sent while issue was closed.
Change committed as 196112

Powered by Google App Engine
This is Rietveld 408576698