Implement read-only indexedb-internals

Implement read-only indexedb-internals

This implements a read-only list of indexeddb instances
in the current profile, including just bare minimum information.

BUG=174188
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194094

[alecflett, 2013-04-10 23:57:48]

This is awaiting the landing of https://codereview.chromium.org/13954002/ - but
in the mean time, could I get a quick review?

[jsbell, 2013-04-11 18:56:20]

Sorry that wasn't quick. ltgm with minor nits/suggestions

https://codereview.chromium.org/14118002/diff/1/content/browser/indexed_db/in...
File content/browser/indexed_db/indexed_db_internals_ui.cc (right):

https://codereview.chromium.org/14118002/diff/1/content/browser/indexed_db/in...
content/browser/indexed_db/indexed_db_internals_ui.cc:49: void
IndexedDBInternalsUI::GetAllOrigins(const base::ListValue* args) {
Add a DCHECK that this is on the UI thread?

https://codereview.chromium.org/14118002/diff/1/content/browser/indexed_db/in...
content/browser/indexed_db/indexed_db_internals_ui.cc:69: bool
sort_by_hostname(const IndexedDBInfo& i, const IndexedDBInfo& j) {
Nit: SortByHostName or e.g. HostNameComparator

https://codereview.chromium.org/14118002/diff/1/content/browser/indexed_db/in...
content/browser/indexed_db/indexed_db_internals_ui.cc:79: sort(origins->begin(),
origins->end(), sort_by_hostname);
Nit: std::sort

https://codereview.chromium.org/14118002/diff/1/content/browser/indexed_db/in...
content/browser/indexed_db/indexed_db_internals_ui.cc:87: void
IndexedDBInternalsUI::OnOriginsReady(
Add a DCHECK that this is on the UI thread?

https://codereview.chromium.org/14118002/diff/1/content/browser/indexed_db/in...
File content/browser/indexed_db/indexed_db_internals_ui.h (right):

https://codereview.chromium.org/14118002/diff/1/content/browser/indexed_db/in...
content/browser/indexed_db/indexed_db_internals_ui.h:31: bool fetching_;
Nit: Add blank line between methods and fields?
(Not technically required by the style guide but used in guide examples and
improves readability.)

https://codereview.chromium.org/14118002/diff/1/content/browser/resources/ind...
File content/browser/resources/indexed_db/indexeddb_internals.html (right):

https://codereview.chromium.org/14118002/diff/1/content/browser/resources/ind...
content/browser/resources/indexed_db/indexeddb_internals.html:23: <span
jscontent="size + ' bytes'"></span>
We may want to make that a friendlier kB/MB at some point.

[jsbell, 2013-04-11 18:56:38]

er, lgtm...

[commit-bot: I haz the power, 2013-04-13 01:47:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/14118002/7001

[commit-bot: I haz the power, 2013-04-13 08:23:48]

Change committed as 194094

[awong, 2013-04-17 21:20:01]

drive by

2 small nits.

https://codereview.chromium.org/14118002/diff/7001/content/browser/indexed_db...
File content/browser/indexed_db/indexed_db_internals_ui.cc (right):

https://codereview.chromium.org/14118002/diff/7001/content/browser/indexed_db...
content/browser/indexed_db/indexed_db_internals_ui.cc:72:
scoped_refptr<IndexedDBContext> context) {
const scoped_refptr<IndexedDBContext>& is preferred here.

https://codereview.chromium.org/14118002/diff/7001/content/browser/indexed_db...
content/browser/indexed_db/indexed_db_internals_ui.cc:99: }
add a newline and comment

} //   namespace content