Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

Issue 14113053: chrome: Use base::MessageLoop. (Part 3) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase again Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
index 99a62f1583f8453da85c02161976d542e744a0c6..fb11630fb4dbc5703d54e74d5cff0034a32900a0 100644
--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
@@ -31,7 +31,7 @@ namespace keys = declarative_webrequest_constants;
TEST(WebRequestConditionAttributeTest, CreateConditionAttribute) {
// Necessary for TestURLRequest.
- MessageLoop message_loop(MessageLoop::TYPE_IO);
+ base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
std::string error;
scoped_refptr<const WebRequestConditionAttribute> result;
@@ -72,7 +72,7 @@ TEST(WebRequestConditionAttributeTest, CreateConditionAttribute) {
TEST(WebRequestConditionAttributeTest, ResourceType) {
// Necessary for TestURLRequest.
- MessageLoop message_loop(MessageLoop::TYPE_IO);
+ base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
std::string error;
ListValue resource_types;
@@ -105,7 +105,7 @@ TEST(WebRequestConditionAttributeTest, ResourceType) {
TEST(WebRequestConditionAttributeTest, ContentType) {
// Necessary for TestURLRequest.
- MessageLoop message_loop(MessageLoop::TYPE_IO);
+ base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
std::string error;
scoped_refptr<const WebRequestConditionAttribute> result;
@@ -122,7 +122,7 @@ TEST(WebRequestConditionAttributeTest, ContentType) {
net::TestURLRequest url_request(
test_server.GetURL("files/headers.html"), &delegate, &context, NULL);
url_request.Start();
- MessageLoop::current()->Run();
+ base::MessageLoop::current()->Run();
ListValue content_types;
content_types.Append(Value::CreateStringValue("text/plain"));
@@ -174,7 +174,7 @@ TEST(WebRequestConditionAttributeTest, ContentType) {
// Testing WebRequestConditionAttributeThirdParty.
TEST(WebRequestConditionAttributeTest, ThirdParty) {
// Necessary for TestURLRequest.
- MessageLoop message_loop(MessageLoop::TYPE_IO);
+ base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
std::string error;
const FundamentalValue value_true(true);
@@ -235,7 +235,7 @@ TEST(WebRequestConditionAttributeTest, ThirdParty) {
// applicable in all stages.
TEST(WebRequestConditionAttributeTest, Stages) {
// Necessary for TestURLRequest.
- MessageLoop message_loop(MessageLoop::TYPE_IO);
+ base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
typedef std::pair<RequestStage, const char*> StageNamePair;
static const StageNamePair active_stages[] = {
@@ -411,7 +411,7 @@ void MatchAndCheck(const std::vector< std::vector<const std::string*> >& tests,
// by both types of condition attributes, so it is enough to test it once.
TEST(WebRequestConditionAttributeTest, RequestHeaders) {
// Necessary for TestURLRequest.
- MessageLoop message_loop(MessageLoop::TYPE_IO);
+ base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
net::TestURLRequestContext context;
net::TestDelegate delegate;
@@ -420,7 +420,7 @@ TEST(WebRequestConditionAttributeTest, RequestHeaders) {
url_request.SetExtraRequestHeaderByName(
"Custom-header", "custom/value", true /* overwrite */);
url_request.Start();
- MessageLoop::current()->Run();
+ base::MessageLoop::current()->Run();
std::vector<std::vector<const std::string*> > tests;
bool result = false;
@@ -489,7 +489,7 @@ TEST(WebRequestConditionAttributeTest, RequestHeaders) {
// 3. Negating the match in case of 'doesNotContainHeaders'.
TEST(WebRequestConditionAttributeTest, ResponseHeaders) {
// Necessary for TestURLRequest.
- MessageLoop message_loop(MessageLoop::TYPE_IO);
+ base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
net::SpawnedTestServer test_server(
net::SpawnedTestServer::TYPE_HTTP,
@@ -503,7 +503,7 @@ TEST(WebRequestConditionAttributeTest, ResponseHeaders) {
net::TestURLRequest url_request(test_server.GetURL("files/headers.html"),
&delegate, &context, NULL);
url_request.Start();
- MessageLoop::current()->Run();
+ base::MessageLoop::current()->Run();
// In all the tests below we assume that the server includes the headers
// Custom-Header: custom/value

Powered by Google App Engine
This is Rietveld 408576698