Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: chrome/browser/net/dns_probe_job_unittest.cc

Issue 14113053: chrome: Use base::MessageLoop. (Part 3) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase again Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/net/dns_probe_job.cc ('k') | chrome/browser/net/dns_probe_service_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/net/dns_probe_job.h" 5 #include "chrome/browser/net/dns_probe_job.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "net/base/net_log.h" 10 #include "net/base/net_log.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 DnsProbeJob::CallbackType callback = base::Bind( 63 DnsProbeJob::CallbackType callback = base::Bind(
64 &DnsProbeJobTest::OnProbeFinished, 64 &DnsProbeJobTest::OnProbeFinished,
65 base::Unretained(this)); 65 base::Unretained(this));
66 66
67 // Need to set these before creating job, because it can call the callback 67 // Need to set these before creating job, because it can call the callback
68 // synchronously in the constructor if both transactions fail to start. 68 // synchronously in the constructor if both transactions fail to start.
69 callback_called_ = false; 69 callback_called_ = false;
70 callback_result_ = DnsProbeJob::SERVERS_UNKNOWN; 70 callback_result_ = DnsProbeJob::SERVERS_UNKNOWN;
71 71
72 // DnsProbeJob needs somewhere to post the callback. 72 // DnsProbeJob needs somewhere to post the callback.
73 scoped_ptr<MessageLoop> message_loop_(new MessageLoopForIO()); 73 scoped_ptr<base::MessageLoop> message_loop_(new base::MessageLoopForIO());
74 74
75 scoped_ptr<DnsProbeJob> job( 75 scoped_ptr<DnsProbeJob> job(
76 DnsProbeJob::CreateJob(dns_client.Pass(), callback, net_log)); 76 DnsProbeJob::CreateJob(dns_client.Pass(), callback, net_log));
77 77
78 // Force callback to run. 78 // Force callback to run.
79 base::RunLoop run_loop; 79 base::RunLoop run_loop;
80 run_loop.RunUntilIdle(); 80 run_loop.RunUntilIdle();
81 } 81 }
82 82
83 void DnsProbeJobTest::OnProbeFinished(DnsProbeJob* job, 83 void DnsProbeJobTest::OnProbeFinished(DnsProbeJob* job,
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 const TestCase* test_case = &kTestCases[i]; 118 const TestCase* test_case = &kTestCases[i];
119 RunProbe(test_case->good_result, test_case->bad_result); 119 RunProbe(test_case->good_result, test_case->bad_result);
120 EXPECT_TRUE(callback_called_); 120 EXPECT_TRUE(callback_called_);
121 EXPECT_EQ(test_case->expected_probe_result, callback_result_); 121 EXPECT_EQ(test_case->expected_probe_result, callback_result_);
122 } 122 }
123 } 123 }
124 124
125 } // namespace 125 } // namespace
126 126
127 } // namespace chrome_browser_net 127 } // namespace chrome_browser_net
OLDNEW
« no previous file with comments | « chrome/browser/net/dns_probe_job.cc ('k') | chrome/browser/net/dns_probe_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698