Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14113050: sync: Use base::MessageLoop. (Closed)

Created:
7 years, 8 months ago by xhwang
Modified:
7 years, 7 months ago
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -82 lines) Patch
M sync/engine/sync_scheduler_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/sync_scheduler_unittest.cc View 1 7 chunks +12 lines, -13 lines 0 comments Download
M sync/engine/syncer_proto_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/syncer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/http_bridge.cc View 1 7 chunks +8 lines, -8 lines 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 1 7 chunks +13 lines, -14 lines 0 comments Download
M sync/internal_api/js_mutation_event_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/js_sync_encryption_handler_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/js_sync_manager_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/engine/passive_model_worker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/util/weak_handle_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_encryption_handler_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_encryption_handler_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sync/js/sync_js_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/ack_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/invalidation_notifier_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/invalidator_factory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/non_blocking_invalidator_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/notifier/registration_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/sync_invalidation_listener_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/sync_system_resources.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/sync_system_resources.cc View 1 5 chunks +9 lines, -9 lines 0 comments Download
M sync/notifier/sync_system_resources_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/sessions/sync_session_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/syncable_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M sync/test/engine/fake_sync_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/engine/fake_sync_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/engine/syncer_command_test.h View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/tools/sync_client.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sync/tools/sync_listen_notifications.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sync/tools/testserver/run_sync_testserver.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/get_session_name_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
xhwang
PTAL
7 years, 8 months ago (2013-04-27 00:44:44 UTC) #1
xhwang
tim@: Could you please OWNERS review this CL?
7 years, 7 months ago (2013-05-04 05:40:45 UTC) #2
tim (not reviewing)
LGTM!
7 years, 7 months ago (2013-05-06 17:58:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/14113050/15001
7 years, 7 months ago (2013-05-06 22:33:50 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 03:52:46 UTC) #5
Message was sent while issue was closed. 
Change committed as 198610

Powered by Google App Engine
This is Rietveld 408576698