Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 14113044: Removed refereces from waterfall to local buildbot interface (Closed)

Created:
7 years, 8 months ago by Ryan Tseng
Modified:
7 years, 8 months ago
Reviewers:
cmp, agable
CC:
chromium-reviews, cmp+cc_chromium.org, cmp
Visibility:
Public.

Description

Removed refereces from waterfall to local buildbot interface We'll re-enable this later when the app is more complete BUG=236041 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M app.py View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Tseng
7 years, 8 months ago (2013-04-26 23:16:08 UTC) #1
cmp
lgtm
7 years, 8 months ago (2013-04-26 23:16:53 UTC) #2
agable
I'll upload a new version once this gets committed. Ryan - do you want to ...
7 years, 8 months ago (2013-04-26 23:20:05 UTC) #3
Ryan Tseng
Committed patchset #1 manually as r196875.
7 years, 8 months ago (2013-04-26 23:21:49 UTC) #4
Ryan Tseng
7 years, 8 months ago (2013-04-26 23:23:55 UTC) #5
Message was sent while issue was closed.
It should be fine.  After this change, devs shouldn't be able to get to the page
serving "new layout" unless they specifically change /p/ to /buildbot/ manually.

Powered by Google App Engine
This is Rietveld 408576698