Issue 14110006: add --enable-spatial-navigation flag for testing

Issue 14110006: add --enable-spatial-navigation flag for testing (Closed)

Created:
7 years, 8 months ago by Mostyn Bramley-Moore

Modified:
7 years, 8 months ago

Reviewers:
jamesr, darin (slow to review), sky, Jói

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Daniel Bratell, eae, esprehn, dmazzoni

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

add --enable-spatial-navigation flag for testing This depends on the following blink patch: https://codereview.chromium.org/13811041/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194875

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -0 lines)			Patch
M	content/browser/web_contents/web_contents_impl.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/public/common/common_param_traits_macros.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/content_switches.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 9 (0 generated)

jamesr

webkit/ lgtm, you'll need someone else for the other bits (see the OWNERS files)

7 years, 8 months ago (2013-04-15 20:22:38 UTC) #2

Mostyn Bramley-Moore

Jói, sky: are you able to look at the content/public/* and content/browser/* changes?

7 years, 8 months ago (2013-04-15 20:36:19 UTC) #3

Mostyn Bramley-Moore

On 2013/04/17 22:47:48, darin wrote: > Running try jobs before committing. The mac_asan failure looks ...

7 years, 8 months ago (2013-04-18 07:07:07 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/14110006/1

7 years, 8 months ago (2013-04-18 07:11:17 UTC) #8

Message was sent while issue was closed.

Change committed as 194875