Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: src/gpu/GrContext.cpp

Issue 14109033: Disable AA for ovals and roundrects if MSAA is enabled (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Fixes from comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/gpu/GrOvalRenderer.h ('k') | src/gpu/GrOvalRenderer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrContext.cpp
===================================================================
--- src/gpu/GrContext.cpp (revision 8926)
+++ src/gpu/GrContext.cpp (working copy)
@@ -980,10 +980,12 @@
GrDrawTarget* target = this->prepareToDraw(&paint, BUFFERED_DRAW);
GrDrawState::AutoStageDisable atr(fDrawState);
- if (!fOvalRenderer->drawSimpleRRect(target, this, paint, rect, stroke)) {
+ bool prAA = paint.isAntiAlias() && !this->getRenderTarget()->isMultisampled();
+
+ if (!fOvalRenderer->drawSimpleRRect(target, this, prAA, rect, stroke)) {
SkPath path;
path.addRRect(rect);
- this->internalDrawPath(target, paint, path, stroke);
+ this->internalDrawPath(target, prAA, path, stroke);
}
}
@@ -996,10 +998,12 @@
GrDrawTarget* target = this->prepareToDraw(&paint, BUFFERED_DRAW);
GrDrawState::AutoStageDisable atr(fDrawState);
- if (!fOvalRenderer->drawOval(target, this, paint, oval, stroke)) {
+ bool useAA = paint.isAntiAlias() && !this->getRenderTarget()->isMultisampled();
+
+ if (!fOvalRenderer->drawOval(target, this, useAA, oval, stroke)) {
SkPath path;
path.addOval(oval);
- this->internalDrawPath(target, paint, path, stroke);
+ this->internalDrawPath(target, useAA, path, stroke);
}
}
@@ -1022,18 +1026,17 @@
SkRect ovalRect;
bool isOval = path.isOval(&ovalRect);
+ bool useAA = paint.isAntiAlias() && !this->getRenderTarget()->isMultisampled();
if (!isOval || path.isInverseFillType()
- || !fOvalRenderer->drawOval(target, this, paint, ovalRect, stroke)) {
- this->internalDrawPath(target, paint, path, stroke);
+ || !fOvalRenderer->drawOval(target, this, useAA, ovalRect, stroke)) {
+ this->internalDrawPath(target, useAA, path, stroke);
}
}
-void GrContext::internalDrawPath(GrDrawTarget* target, const GrPaint& paint, const SkPath& path,
+void GrContext::internalDrawPath(GrDrawTarget* target, bool useAA, const SkPath& path,
const SkStrokeRec& stroke) {
- bool prAA = paint.isAntiAlias() && !this->getRenderTarget()->isMultisampled();
-
// An Assumption here is that path renderer would use some form of tweaking
// the src color (either the input alpha or in the frag shader) to implement
// aa. If we have some future driver-mojo path AA that can do the right
@@ -1042,11 +1045,11 @@
#if GR_DEBUG
//GrPrintf("Turning off AA to correctly apply blend.\n");
#endif
- prAA = false;
+ useAA = false;
}
- GrPathRendererChain::DrawType type = prAA ? GrPathRendererChain::kColorAntiAlias_DrawType :
- GrPathRendererChain::kColor_DrawType;
+ GrPathRendererChain::DrawType type = useAA ? GrPathRendererChain::kColorAntiAlias_DrawType :
+ GrPathRendererChain::kColor_DrawType;
const SkPath* pathPtr = &path;
SkPath tmpPath;
@@ -1074,7 +1077,7 @@
return;
}
- pr->drawPath(*pathPtr, strokeRec, target, prAA);
+ pr->drawPath(*pathPtr, strokeRec, target, useAA);
}
////////////////////////////////////////////////////////////////////////////////
« no previous file with comments | « include/gpu/GrOvalRenderer.h ('k') | src/gpu/GrOvalRenderer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698