Issue 14109033: Disable AA for ovals and roundrects if MSAA is enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14109033: Disable AA for ovals and roundrects if MSAA is enabled (Closed)

Created:
7 years, 7 months ago by jvanverth1

Modified:
7 years, 7 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Disable AA for ovals and roundrects if MSAA is enabled. Also remove GrPaint from a number of methods -- we only use it to get the AA state. Committed: http://code.google.com/p/skia/source/detail?r=8954

Patch Set 1 #

Patch Set 2 : Fix roundrects #

Total comments: 2

Patch Set 3 : Rebase to head #

Patch Set 4 : Fixes from comments #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -31 lines)			Patch
M	include/gpu/GrContext.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	include/gpu/GrOvalRenderer.h	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	1 2 3	5 chunks	+16 lines, -13 lines	0 comments	Download
M	src/gpu/GrOvalRenderer.cpp	View	1 2 3	6 chunks	+16 lines, -12 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bsalomon

minor nits below, lgtm https://codereview.chromium.org/14109033/diff/1005/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.chromium.org/14109033/diff/1005/src/gpu/GrContext.cpp#newcode983 src/gpu/GrContext.cpp:983: bool prAA = paint.isAntiAlias() && ...

7 years, 7 months ago (2013-04-29 21:17:08 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/14109033/8001

7 years, 7 months ago (2013-05-02 13:03:58 UTC) #3

Message was sent while issue was closed.

Change committed as 8954

Expand Messages | Collapse Messages