Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 14109022: Fix archiving and running Chromium.app on OSX with target chrome_run. (Closed)

Created:
7 years, 8 months ago by M-A Ruel
Modified:
7 years, 8 months ago
Reviewers:
csharp
CC:
chromium-reviews, Vadim Sh.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix archiving and running Chromium.app on OSX with target chrome_run. All the necessary files, like resources.pak and ffmpegsumo.so, are already mapping deep inside Chromium.app/. Mapping the ones in PRODUCT_DIR is useless. Technically, Chromium.dmg could be used but it's harder to start from the command line, and mapping each individual files permits caching modules that haven't changed, like the resource files. TBR=csharp@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M chrome/chrome.isolate View 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
7 years, 8 months ago (2013-04-19 19:13:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/14109022/1
7 years, 8 months ago (2013-04-19 19:17:20 UTC) #2
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=119911
7 years, 8 months ago (2013-04-19 22:27:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/14109022/1
7 years, 8 months ago (2013-04-20 00:10:12 UTC) #4
commit-bot: I haz the power
Change committed as 195351
7 years, 8 months ago (2013-04-20 00:55:16 UTC) #5
csharp
7 years, 8 months ago (2013-04-22 14:51:52 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698