Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 14108009: chromeos: Use WriteBatch to update DriveResourceMetadata DB (Closed)

Created:
7 years, 8 months ago by hashimoto
Modified:
7 years, 8 months ago
Reviewers:
hidehiko
CC:
chromium-reviews, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Use WriteBatch to update DriveResourceMetadata DB DriveResourceMetadataStorage::PutEntry/RemoveEntry is responsible to manage parent-child relationship. Rename DriveResourceMetadata::RemoveDirectoryChild to RemoveEntryRecursively. Return error from DriveResourceMetadata::AddEntryToDirectory/RemoveEntryRecursively. DriveResourceMetadata::AddEntryToDirectory is responsible to remove an entry from its old parent. BUG=234110 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196119

Patch Set 1 : #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : rename method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -198 lines) Patch
M chrome/browser/chromeos/drive/drive_resource_metadata.h View 1 2 1 chunk +8 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_resource_metadata.cc View 1 2 10 chunks +39 lines, -56 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_resource_metadata_storage.h View 2 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_resource_metadata_storage.cc View 6 chunks +49 lines, -42 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_resource_metadata_storage_unittest.cc View 11 chunks +99 lines, -73 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc View 1 1 chunk +18 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
Please review. This change depends on https://chromiumcodereview.appspot.com/14091012/ ("Rewrite DriveResourceMetadata::MoveEntryToDirectory with RefreshEntry").
7 years, 8 months ago (2013-04-24 04:01:54 UTC) #1
hidehiko
https://chromiumcodereview.appspot.com/14108009/diff/6001/chrome/browser/chromeos/drive/drive_resource_metadata.cc File chrome/browser/chromeos/drive/drive_resource_metadata.cc (right): https://chromiumcodereview.appspot.com/14108009/diff/6001/chrome/browser/chromeos/drive/drive_resource_metadata.cc#newcode911 chrome/browser/chromeos/drive/drive_resource_metadata.cc:911: bool DriveResourceMetadata::AddEntryToDirectory(const DriveEntryProto& entry) { AddEntryToDirectory sounds weird because ...
7 years, 8 months ago (2013-04-24 07:29:45 UTC) #2
hashimoto
https://codereview.chromium.org/14108009/diff/6001/chrome/browser/chromeos/drive/drive_resource_metadata.cc File chrome/browser/chromeos/drive/drive_resource_metadata.cc (right): https://codereview.chromium.org/14108009/diff/6001/chrome/browser/chromeos/drive/drive_resource_metadata.cc#newcode911 chrome/browser/chromeos/drive/drive_resource_metadata.cc:911: bool DriveResourceMetadata::AddEntryToDirectory(const DriveEntryProto& entry) { On 2013/04/24 07:29:45, hidehiko ...
7 years, 8 months ago (2013-04-24 08:05:56 UTC) #3
hidehiko
lgtm
7 years, 8 months ago (2013-04-24 08:18:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/14108009/15001
7 years, 8 months ago (2013-04-24 09:17:32 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-24 11:41:59 UTC) #6
Message was sent while issue was closed.
Change committed as 196119

Powered by Google App Engine
This is Rietveld 408576698