Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 14108006: Android: Re-enable three Breakpad unit tests that were previously failing. (Closed)

Created:
7 years, 8 months ago by digit1
Modified:
7 years, 7 months ago
Reviewers:
pliard, ppi
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Android: Re-enable three Breakpad unit tests that were previously failing. The tests were fixed by the following already-rolled upstream Breakpad patch: https://breakpad.appspot.com/540002/ BUG=165916 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/android/pylib/gtest/filter/breakpad_unittests_disabled View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
digit1
7 years, 8 months ago (2013-04-24 14:50:17 UTC) #1
ppi
Awesome, lgtm! (note that I am not a committer)
7 years, 8 months ago (2013-04-24 14:54:04 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 8 months ago (2013-04-26 14:13:04 UTC) #3
Philippe
On 2013/04/26 14:13:04, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
7 years, 8 months ago (2013-04-26 14:14:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/14108006/1
7 years, 8 months ago (2013-04-26 14:15:09 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=107433
7 years, 8 months ago (2013-04-26 16:12:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/14108006/1
7 years, 7 months ago (2013-04-29 13:56:18 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-04-29 15:06:56 UTC) #8
Message was sent while issue was closed.
Change committed as 197039

Powered by Google App Engine
This is Rietveld 408576698