Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 14107007: Moved Google Update and install related code to cloud_print/common (Closed)

Created:
7 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 8 months ago
Reviewers:
gene
CC:
chromium-reviews
Visibility:
Public.

Description

Moved Google Update and install related code to cloud_print/common R=gene Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194799

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -162 lines) Patch
M cloud_print/cloud_print.gyp View 1 1 chunk +11 lines, -0 lines 0 comments Download
M cloud_print/common/win/cloud_print_utils.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M cloud_print/common/win/cloud_print_utils.cc View 1 2 chunks +21 lines, -0 lines 0 comments Download
A cloud_print/common/win/install_utils.h View 1 1 chunk +40 lines, -0 lines 0 comments Download
A cloud_print/common/win/install_utils.cc View 1 1 chunk +163 lines, -0 lines 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 1 18 chunks +34 lines, -148 lines 0 comments Download
M cloud_print/virtual_driver/win/install/virtual_driver_install.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M cloud_print/virtual_driver/win/virtual_driver_consts.h View 1 chunk +1 line, -2 lines 0 comments Download
M cloud_print/virtual_driver/win/virtual_driver_consts.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 8 months ago (2013-04-15 19:24:29 UTC) #1
gene
lgtm
7 years, 8 months ago (2013-04-15 19:26:22 UTC) #2
Vitaly Buka (NO REVIEWS)
Moved more code.
7 years, 8 months ago (2013-04-16 00:30:29 UTC) #3
gene
still lgtm
7 years, 8 months ago (2013-04-16 00:51:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14107007/21002
7 years, 8 months ago (2013-04-18 00:20:24 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=135979
7 years, 8 months ago (2013-04-18 03:16:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14107007/21002
7 years, 8 months ago (2013-04-18 03:19:55 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 06:03:15 UTC) #8
Message was sent while issue was closed.
Change committed as 194799

Powered by Google App Engine
This is Rietveld 408576698