Issue 14103027: Use screen size to calculate channel distance in scroll snapping

Issue 14103027: Use screen size to calculate channel distance in scroll snapping (Closed)

Created:
7 years, 8 months ago by Yusuf

Modified:
7 years, 8 months ago

Reviewers:
Ted C

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use screen size to calculate channel distance in scroll snapping The channel distance had a fixed value before which was leading to going out of snapping mode unnecessarily. Making it dependent on the screen size. BUG=178610 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194961

Patch Set 1 #

Patch Set 2 : Styling fix #

Total comments: 4

Patch Set 3 : Nits #

Patch Set 4 : Fix findbugs warning #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -7 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	content/public/android/java/src/org/chromium/content/browser/SnapScrollController.java	View	1 2 3	5 chunks	+27 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ted C

lgtm https://codereview.chromium.org/14103027/diff/2001/content/public/android/java/src/org/chromium/content/browser/SnapScrollController.java File content/public/android/java/src/org/chromium/content/browser/SnapScrollController.java (right): https://codereview.chromium.org/14103027/diff/2001/content/public/android/java/src/org/chromium/content/browser/SnapScrollController.java#newcode107 content/public/android/java/src/org/chromium/content/browser/SnapScrollController.java:107: final double screenSize = Math.hypot(metrics.widthPixels/metrics.densityDpi, spaces around / ...

7 years, 8 months ago (2013-04-15 23:52:09 UTC) #2

Yusuf

https://codereview.chromium.org/14103027/diff/2001/content/public/android/java/src/org/chromium/content/browser/SnapScrollController.java File content/public/android/java/src/org/chromium/content/browser/SnapScrollController.java (right): https://codereview.chromium.org/14103027/diff/2001/content/public/android/java/src/org/chromium/content/browser/SnapScrollController.java#newcode107 content/public/android/java/src/org/chromium/content/browser/SnapScrollController.java:107: final double screenSize = Math.hypot(metrics.widthPixels/metrics.densityDpi, On 2013/04/15 23:52:09, Ted ...

7 years, 8 months ago (2013-04-16 00:00:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/14103027/9001

7 years, 8 months ago (2013-04-18 17:34:03 UTC) #4

Message was sent while issue was closed.

Change committed as 194961

Expand Messages | Collapse Messages