Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 14103008: Add support for unsigned int64 in string_number_conversions (Closed)

Created:
7 years, 8 months ago by felipeg
Modified:
7 years, 8 months ago
Reviewers:
brettw, gavinp
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Add support for unsigned int64 in string_number_conversions BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193933

Patch Set 1 #

Patch Set 2 : unittests #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -1 line) Patch
M base/strings/string_number_conversions.h View 2 chunks +6 lines, -1 line 0 comments Download
M base/strings/string_number_conversions.cc View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M base/strings/string_number_conversions_unittest.cc View 1 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
felipeg
7 years, 8 months ago (2013-04-11 16:45:09 UTC) #1
brettw
lgtm https://codereview.chromium.org/14103008/diff/2001/base/strings/string_number_conversions.cc File base/strings/string_number_conversions.cc (right): https://codereview.chromium.org/14103008/diff/2001/base/strings/string_number_conversions.cc#newcode504 base/strings/string_number_conversions.cc:504: input.begin(), input.end(), output); Indent 2 more spaces.
7 years, 8 months ago (2013-04-11 18:18:14 UTC) #2
felipeg
https://codereview.chromium.org/14103008/diff/2001/base/strings/string_number_conversions.cc File base/strings/string_number_conversions.cc (right): https://codereview.chromium.org/14103008/diff/2001/base/strings/string_number_conversions.cc#newcode504 base/strings/string_number_conversions.cc:504: input.begin(), input.end(), output); On 2013/04/11 18:18:15, brettw wrote: > ...
7 years, 8 months ago (2013-04-12 11:41:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felipeg@chromium.org/14103008/5001
7 years, 8 months ago (2013-04-12 11:41:56 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-12 14:38:15 UTC) #5
Message was sent while issue was closed.
Change committed as 193933

Powered by Google App Engine
This is Rietveld 408576698