Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 14100009: Remove spelling markers when disabling spellcheck (Closed)

Created:
7 years, 8 months ago by please use gerrit instead
Modified:
7 years, 8 months ago
Reviewers:
rpetterson
CC:
chromium-reviews, groby+spellwatch_chromium.org, rpetterson, rouslan+spellwatch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove spelling markers when disabling spellcheck This patch removes spelling markers from text fields when the user disables "Check spelling of text fields" option. BUG=125508 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/renderer/spellchecker/spellcheck_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
please use gerrit instead
Rlp: PTAL. The corresponding Blink change is in https://codereview.chromium.org/13896014/
7 years, 8 months ago (2013-04-18 19:58:36 UTC) #1
rpetterson
lgtm
7 years, 8 months ago (2013-04-18 22:16:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/14100009/1
7 years, 8 months ago (2013-04-18 23:26:37 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-18 23:45:04 UTC) #4
please use gerrit instead
Need to wait for Blink DEPS roll.
7 years, 8 months ago (2013-04-19 00:45:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/14100009/1
7 years, 8 months ago (2013-04-19 16:28:50 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 18:46:37 UTC) #7
Message was sent while issue was closed.
Change committed as 195249

Powered by Google App Engine
This is Rietveld 408576698