[Android] Moving input related files to a separate input/ directory.

[Android] Moving input related files to a separate input/ directory.

Cleaning up the content/public/android/java/src/.. ../content/browser/
directory by moving input related classes to a separate directory.

BUG=230059
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193760

[aurimas (slooooooooow), 2013-04-10 20:53:06]

Hey Nilesh,

Please take a look at this change. It only moves a few files to a different
directory.

Aurimas

[nilesh, 2013-04-10 20:59:16]

On 2013/04/10 20:53:06, aurimas wrote:
> Hey Nilesh,
> 
> Please take a look at this change. It only moves a few files to a different
> directory.
> 
> Aurimas

No other files using these classes?

[nilesh, 2013-04-10 23:12:59]

Some nits. Thanks a lot for doing this.

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
File
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
(right):

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:54:
public void onImeEvent(boolean isFinish);
you can remove public from the interface methods.

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:61:
static final int COMPOSITION_KEY_CODE = 229;
private

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:71:
public static int sTextInputTypeNone;
this is not a constant, should have a getter of its own.

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:74:
static int sTextInputTypePassword;
All of these can be private.

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:444:
public boolean unselect() {
Please add java-doc for some of these.

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:489:
public static class AdapterInputConnection extends BaseInputConnection {
This public static class is a good candidate for moving into its own file.
Please add a TODO (in my or your name) to do it.

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
File
content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java
(right):

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java:16:
public class InputMethodManagerWrapper {
this can be package/default visibility.

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
File
content/public/android/java/src/org/chromium/content/browser/input/SelectionHandleController.java
(right):

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/SelectionHandleController.java:124:
private void setStartHandlePosition(int x, int y) {
looks like you can remove the int version of these methods.

[aurimas (slooooooooow), 2013-04-11 01:02:43]

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
File
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
(right):

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:54:
public void onImeEvent(boolean isFinish);
On 2013/04/10 23:12:59, nilesh wrote:
> you can remove public from the interface methods.

Done.

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:61:
static final int COMPOSITION_KEY_CODE = 229;
On 2013/04/10 23:12:59, nilesh wrote:
> private

Done.

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:71:
public static int sTextInputTypeNone;
On 2013/04/10 23:12:59, nilesh wrote:
> this is not a constant, should have a getter of its own.

Done.

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:74:
static int sTextInputTypePassword;
On 2013/04/10 23:12:59, nilesh wrote:
> All of these can be private.

Done.

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:444:
public boolean unselect() {
On 2013/04/10 23:12:59, nilesh wrote:
> Please add java-doc for some of these.

Done.

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:489:
public static class AdapterInputConnection extends BaseInputConnection {
On 2013/04/10 23:12:59, nilesh wrote:
> This public static class is a good candidate for moving into its own file.
> Please add a TODO (in my or your name) to do it.

I moved it out.

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
File
content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java
(right):

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java:16:
public class InputMethodManagerWrapper {
On 2013/04/10 23:12:59, nilesh wrote:
> this can be package/default visibility.

Done.

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
File
content/public/android/java/src/org/chromium/content/browser/input/SelectionHandleController.java
(right):

https://codereview.chromium.org/14100003/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/input/SelectionHandleController.java:124:
private void setStartHandlePosition(int x, int y) {
On 2013/04/10 23:12:59, nilesh wrote:
> looks like you can remove the int version of these methods.

Done.

[nilesh, 2013-04-11 17:10:00]

https://codereview.chromium.org/14100003/diff/25001/chrome/android/javatests/...
File
chrome/android/javatests/src/org/chromium/chrome/browser/test/input/SelectPopupOtherContentViewTest.java
(right):

https://codereview.chromium.org/14100003/diff/25001/chrome/android/javatests/...
chrome/android/javatests/src/org/chromium/chrome/browser/test/input/SelectPopupOtherContentViewTest.java:5:
package org.chromium.chrome.browser.test.input;
Move this to org.chromium.chrome.browser

https://codereview.chromium.org/14100003/diff/25001/content/public/android/ja...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(left):

https://codereview.chromium.org/14100003/diff/25001/content/public/android/ja...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:2061:
// Non-breaking spaces can cause the IME to get confused. Replace with normal
spaces.
merge error here and below?

https://codereview.chromium.org/14100003/diff/25001/content/public/android/ja...
File
content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java
(right):

https://codereview.chromium.org/14100003/diff/25001/content/public/android/ja...
content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java:27:
"org.chromium.content.browser.ImeAdapter$AdapterInputConnection";
org.chromium.content.browser.input.AdapterInputConnection

https://codereview.chromium.org/14100003/diff/25001/content/public/android/ja...
content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java:357:
protected AdapterInputConnection(View view, ImeAdapter imeAdapter, EditorInfo
outAttrs) {
Move constructor to the top.

[aurimas (slooooooooow), 2013-04-11 17:30:17]

https://codereview.chromium.org/14100003/diff/25001/chrome/android/javatests/...
File
chrome/android/javatests/src/org/chromium/chrome/browser/test/input/SelectPopupOtherContentViewTest.java
(right):

https://codereview.chromium.org/14100003/diff/25001/chrome/android/javatests/...
chrome/android/javatests/src/org/chromium/chrome/browser/test/input/SelectPopupOtherContentViewTest.java:5:
package org.chromium.chrome.browser.test.input;
On 2013/04/11 17:10:00, nilesh wrote:
> Move this to org.chromium.chrome.browser

Done.

https://codereview.chromium.org/14100003/diff/25001/content/public/android/ja...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(left):

https://codereview.chromium.org/14100003/diff/25001/content/public/android/ja...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:2061:
// Non-breaking spaces can cause the IME to get confused. Replace with normal
spaces.
On 2013/04/11 17:10:00, nilesh wrote:
> merge error here and below?

I moved this to AdapterInputConnection#setEditable() where it was supposed to be
in the first place.

https://codereview.chromium.org/14100003/diff/25001/content/public/android/ja...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:2072:
// In WebKit if there's a composition then the selection will usually be the
This is no longer the case. It was something that was there for Chrome M18's
WebKit.

https://codereview.chromium.org/14100003/diff/25001/content/public/android/ja...
File
content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java
(right):

https://codereview.chromium.org/14100003/diff/25001/content/public/android/ja...
content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java:27:
"org.chromium.content.browser.ImeAdapter$AdapterInputConnection";
On 2013/04/11 17:10:00, nilesh wrote:
> org.chromium.content.browser.input.AdapterInputConnection

Done.

https://codereview.chromium.org/14100003/diff/25001/content/public/android/ja...
content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java:357:
protected AdapterInputConnection(View view, ImeAdapter imeAdapter, EditorInfo
outAttrs) {
On 2013/04/11 17:10:00, nilesh wrote:
> Move constructor to the top.

Done.

[nilesh, 2013-04-11 18:03:54]

LGTM with nits

https://codereview.chromium.org/14100003/diff/34002/content/public/android/ja...
File
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
(right):

https://codereview.chromium.org/14100003/diff/34002/content/public/android/ja...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:79:
static int sEventTypeRawKeyDown;
You should make these private if they are not needed from the Java code.

https://codereview.chromium.org/14100003/diff/34002/content/public/android/ja...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:107:
final SelectionHandleController mSelectionHandleController;
add package private getters for the handler controllers.

https://codereview.chromium.org/14100003/diff/34002/content/public/android/ja...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:109:
int mTextInputType;
these 3 can be private?

https://codereview.chromium.org/14100003/diff/34002/content/public/android/ja...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:445:
* @return Whether the C++ counterpart of ImeAdapter received the call.
native counterpart 
(here and below(

[aurimas (slooooooooow), 2013-04-11 20:40:26]

https://codereview.chromium.org/14100003/diff/34002/content/public/android/ja...
File
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
(right):

https://codereview.chromium.org/14100003/diff/34002/content/public/android/ja...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:79:
static int sEventTypeRawKeyDown;
On 2013/04/11 18:03:55, nilesh wrote:
> You should make these private if they are not needed from the Java code.

This is used in AdapterInputConnection constructor.

https://codereview.chromium.org/14100003/diff/34002/content/public/android/ja...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:107:
final SelectionHandleController mSelectionHandleController;
On 2013/04/11 18:03:55, nilesh wrote:
> add package private getters for the handler controllers.

Done.

https://codereview.chromium.org/14100003/diff/34002/content/public/android/ja...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:109:
int mTextInputType;
On 2013/04/11 18:03:55, nilesh wrote:
> these 3 can be private?

Done.

https://codereview.chromium.org/14100003/diff/34002/content/public/android/ja...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:445:
* @return Whether the C++ counterpart of ImeAdapter received the call.
On 2013/04/11 18:03:55, nilesh wrote:
> native counterpart 
> (here and below(

Done.

[aurimas (slooooooooow), 2013-04-11 20:41:40]

+yfriedman for content/content_jni.gypi change

[Yaron, 2013-04-11 20:50:26]

lgtm

[commit-bot: I haz the power, 2013-04-11 21:37:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/14100003/46001

[commit-bot: I haz the power, 2013-04-11 21:38:50]

Change committed as 193760