Fix x.runtimeType for native classes

sdk/lib/_internal/compiler/implementation/resolution/members.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of resolution;
 
 abstract class TreeElements {
   Element get currentElement;
   Set<Node> get superUses;
 
@@ skipping 3170 matching lines @@
         Link<Node> link = superMixin.mixins.nodes;
         while (!link.isEmpty) {
           supertype = applyMixin(supertype, resolveType(link.head));
           link = link.tail;
         }
         element.supertype = supertype;
       } else {
         element.supertype = resolveSupertype(element, node.superclass);
       }
     }
-
     // If the super type isn't specified, we make it Object.

[karlklose, 2013/04/24 14:27:28]

Please update the comment.

[sra1, 2013/04/24 17:32:43]

Done.

-    final objectElement = compiler.objectClass;
-    if (!identical(element, objectElement) && element.supertype == null) {
-      if (objectElement == null) {
-        compiler.internalError("Internal error: cannot resolve Object",
-                               node: node);
-      } else {
-        objectElement.ensureResolved(compiler);
+    if (element.supertype == null && element != compiler.objectClass) {

[ngeoffray, 2013/04/24 06:58:13]

This code looks kind of convoluted. I'd prefer having a isNative check
explicitly.

[sra1, 2013/04/24 17:32:43]

Since this is the resolver we should use the backend otherwise we would break
dart2dart.  So 'isNative()' should not really be here.

+      final superElement = compiler.backend.defaultSuperclass(element);

[ngeoffray, 2013/04/24 06:58:13]

final -> ClassElement

[sra1, 2013/04/24 17:32:43]

Done.

+      if (element != superElement) {  // I.e. don't make Object extend Object.

[ngeoffray, 2013/04/24 06:58:13]

You already made that test (don't make Object extend Object) line 3192.

[sra1, 2013/04/24 17:32:43]

Not quite true.  I'll clarify the comment. We dont want Interceptor to extend
Interceptor either.

+        if (superElement == null) {
+          compiler.internalError("Internal error: cannot resolve Object",
+              node: node);
+        } else {
+          superElement.ensureResolved(compiler);
+        }
+        element.supertype = superElement.computeType(compiler);
       }
-      element.supertype = objectElement.computeType(compiler);
     }
 
     assert(element.interfaces == null);
     element.interfaces = resolveInterfaces(node.interfaces, node.superclass);
     calculateAllSupertypes(element);
 
     if (node.defaultClause != null) {
       element.defaultClass = visit(node.defaultClause);
     }
     element.addDefaultConstructorIfNeeded(compiler);
@@ skipping 748 matching lines @@
     return e;
   }
 
   /// Assumed to be called by [resolveRedirectingFactory].
   Element visitReturn(Return node) {
     Node expression = node.expression;
     return finishConstructorReference(visit(expression),
                                       expression, expression);
   }
 }