Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 14098008: Exctracted small setup executable. (Closed)

Created:
7 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 8 months ago
Reviewers:
gene
CC:
chromium-reviews
Visibility:
Public.

Description

Exctracted small setup executable. R=gene Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -23 lines) Patch
M cloud_print/cloud_print.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cloud_print/service/service.gyp View 2 chunks +25 lines, -2 lines 0 comments Download
M cloud_print/service/win/chrome_launcher.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cloud_print/service/win/chrome_launcher.cc View 4 chunks +3 lines, -12 lines 0 comments Download
M cloud_print/service/win/cloud_print_service_config.cc View 2 chunks +0 lines, -5 lines 0 comments Download
A cloud_print/service/win/cloud_print_service_setup_exe.ver View 1 chunk +3 lines, -0 lines 0 comments Download
M cloud_print/service/win/installer.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M cloud_print/service/win/service_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M cloud_print/service/win/service_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cloud_print/service/win/service_utils.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 8 months ago (2013-04-23 22:46:42 UTC) #1
gene
lgtm
7 years, 8 months ago (2013-04-23 23:18:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14098008/1
7 years, 8 months ago (2013-04-23 23:19:07 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-24 02:37:57 UTC) #4
Message was sent while issue was closed.
Change committed as 196007

Powered by Google App Engine
This is Rietveld 408576698