Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: cc/layers/io_surface_layer_impl.cc

Issue 14098007: cc: Add a test that the IOSurface drawing path makes the right context calls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/trees/layer_tree_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/io_surface_layer_impl.cc
diff --git a/cc/layers/io_surface_layer_impl.cc b/cc/layers/io_surface_layer_impl.cc
index c5da815ce05576c0233578d9df1f388856d7fa67..b09ee332c9d56b89f3e4f93698a5f8a9ad461c14 100644
--- a/cc/layers/io_surface_layer_impl.cc
+++ b/cc/layers/io_surface_layer_impl.cc
@@ -81,22 +81,9 @@ void IOSurfaceLayerImpl::WillDraw(ResourceProvider* resource_provider) {
io_surface_texture_id_);
}
- GLC(context3d, context3d->activeTexture(GL_TEXTURE0));
jamesr 2013/04/19 00:05:09 what was the actual bug? this call?
danakj 2013/04/19 00:06:41 mac context virtualization is the bug on TOT. the
danakj 2013/04/19 00:07:05 I think this call is just redundant cuz we're alwa
GLC(context3d,
context3d->bindTexture(GL_TEXTURE_RECTANGLE_ARB,
io_surface_texture_id_));
- GLC(context3d,
- context3d->texParameteri(
- GL_TEXTURE_RECTANGLE_ARB, GL_TEXTURE_MIN_FILTER, GL_LINEAR));
- GLC(context3d,
- context3d->texParameteri(
- GL_TEXTURE_RECTANGLE_ARB, GL_TEXTURE_MAG_FILTER, GL_LINEAR));
- GLC(context3d,
- context3d->texParameteri(
- GL_TEXTURE_RECTANGLE_ARB, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE));
- GLC(context3d,
- context3d->texParameteri(
- GL_TEXTURE_RECTANGLE_ARB, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE));
context3d->texImageIOSurface2DCHROMIUM(GL_TEXTURE_RECTANGLE_ARB,
io_surface_size_.width(),
io_surface_size_.height(),
« no previous file with comments | « no previous file | cc/trees/layer_tree_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698