Issue 14096009: [Autofill] Split off AutofillDataModel as a subclass of FormData.

Issue 14096009: [Autofill] Split off AutofillDataModel as a subclass of FormData. (Closed)

Created:
7 years, 8 months ago by Ilya Sherman

Modified:
7 years, 8 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Autofill] Split off AutofillDataModel as a subclass of FormData. BUG=170401, 231029 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195071

Patch Set 1 #

Patch Set 2 : git add the new files #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase harder #

Patch Set 5 : Re-rebase #

Patch Set 6 : Re-rebase harder #

Patch Set 7 : operator= should still copy guids #

Patch Set 8 : Fix Android compile #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -371 lines)			Patch
M	chrome/browser/autofill/android/personal_data_manager_android.cc	View	1 2 3 4 5 6 7	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_dialog_controller_impl.h	View	1 2	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc	View	1 2	4 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/autofill/data_model_wrapper.h	View		4 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/autofill/data_model_wrapper.cc	View		6 chunks	+15 lines, -14 lines	0 comments	Download
M	components/autofill.gypi	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	components/autofill/browser/address.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	components/autofill/browser/autofill_data_model.h	View	1	1 chunk	+55 lines, -0 lines	0 comments	Download
A +	components/autofill/browser/autofill_data_model.cc	View	1 2 3 4 5	3 chunks	+12 lines, -64 lines	0 comments	Download
M	components/autofill/browser/autofill_manager.h	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	components/autofill/browser/autofill_manager.cc	View		8 chunks	+13 lines, -13 lines	0 comments	Download
M	components/autofill/browser/autofill_profile.h	View		6 chunks	+5 lines, -12 lines	0 comments	Download
M	components/autofill/browser/autofill_profile.cc	View	1 2 3 4 5 6	4 chunks	+6 lines, -10 lines	0 comments	Download
M	components/autofill/browser/contact_info.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/autofill/browser/credit_card.h	View		5 chunks	+6 lines, -12 lines	0 comments	Download
M	components/autofill/browser/credit_card.cc	View	1 2 3 4 5 6	4 chunks	+11 lines, -16 lines	0 comments	Download
M	components/autofill/browser/form_group.h	View	3 4	3 chunks	+0 lines, -29 lines	0 comments	Download
M	components/autofill/browser/form_group.cc	View	1 2 3 4	2 chunks	+0 lines, -182 lines	0 comments	Download
M	components/autofill/browser/personal_data_manager.cc	View	3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/autofill/browser/wallet/wallet_address.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/autofill/browser/webdata/autofill_change.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/autofill/browser/webdata/autofill_table_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/14096009/36017

7 years, 8 months ago (2013-04-18 16:53:09 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 8 months ago (2013-04-18 17:54:34 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/14096009/36017

7 years, 8 months ago (2013-04-18 22:01:58 UTC) #5

Message was sent while issue was closed.

Change committed as 195071

Expand Messages | Collapse Messages