Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java

Issue 1409433002: Disable state saving for TextViewWithClickableSpans. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java
diff --git a/ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java b/ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java
index 6efa8761becc7562d178f712c68c35f9c29c5b72..184172ab4e32405e6a38570c5050d18d798b3641 100644
--- a/ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java
+++ b/ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java
@@ -46,6 +46,10 @@ public class TextViewWithClickableSpans extends TextView {
}
private void init() {
+ // This disables the saving/restoring since the saved text may be in the wrong language
+ // (if the user just changed system language), and restoring spans doesn't work anyway.
+ // See crbug.com/533362
+ setSaveEnabled(false);
mAccessibilityManager = (AccessibilityManager)
getContext().getSystemService(Context.ACCESSIBILITY_SERVICE);
setOnLongClickListener(new View.OnLongClickListener() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698