Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Side by Side Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 14093027: Add histogram for image errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update to use SPARSE_SLOWLY Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // See http://dev.chromium.org/developers/design-documents/multi-process-resourc e-loading 5 // See http://dev.chromium.org/developers/design-documents/multi-process-resourc e-loading
6 6
7 #include "content/browser/loader/resource_dispatcher_host_impl.h" 7 #include "content/browser/loader/resource_dispatcher_host_impl.h"
8 8
9 #include <set> 9 #include <set>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/bind.h" 12 #include "base/bind.h"
13 #include "base/bind_helpers.h" 13 #include "base/bind_helpers.h"
14 #include "base/command_line.h" 14 #include "base/command_line.h"
15 #include "base/compiler_specific.h" 15 #include "base/compiler_specific.h"
16 #include "base/debug/alias.h" 16 #include "base/debug/alias.h"
17 #include "base/logging.h" 17 #include "base/logging.h"
18 #include "base/memory/scoped_ptr.h" 18 #include "base/memory/scoped_ptr.h"
19 #include "base/message_loop.h" 19 #include "base/message_loop.h"
20 #include "base/metrics/histogram.h" 20 #include "base/metrics/histogram.h"
21 #include "base/metrics/sparse_histogram.h"
21 #include "base/shared_memory.h" 22 #include "base/shared_memory.h"
22 #include "base/stl_util.h" 23 #include "base/stl_util.h"
23 #include "base/third_party/dynamic_annotations/dynamic_annotations.h" 24 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
24 #include "content/browser/appcache/chrome_appcache_service.h" 25 #include "content/browser/appcache/chrome_appcache_service.h"
25 #include "content/browser/cert_store_impl.h" 26 #include "content/browser/cert_store_impl.h"
26 #include "content/browser/child_process_security_policy_impl.h" 27 #include "content/browser/child_process_security_policy_impl.h"
27 #include "content/browser/cross_site_request_manager.h" 28 #include "content/browser/cross_site_request_manager.h"
28 #include "content/browser/download/download_resource_handler.h" 29 #include "content/browser/download/download_resource_handler.h"
29 #include "content/browser/download/save_file_manager.h" 30 #include "content/browser/download/save_file_manager.h"
30 #include "content/browser/download/save_file_resource_handler.h" 31 #include "content/browser/download/save_file_resource_handler.h"
(...skipping 703 matching lines...) Expand 10 before | Expand all | Expand 10 after
734 render_process_id, render_view_id, base::Passed(&detail))); 735 render_process_id, render_view_id, base::Passed(&detail)));
735 } 736 }
736 737
737 void ResourceDispatcherHostImpl::DidFinishLoading(ResourceLoader* loader) { 738 void ResourceDispatcherHostImpl::DidFinishLoading(ResourceLoader* loader) {
738 ResourceRequestInfo* info = loader->GetRequestInfo(); 739 ResourceRequestInfo* info = loader->GetRequestInfo();
739 740
740 // Record final result of all resource loads. 741 // Record final result of all resource loads.
741 if (info->GetResourceType() == ResourceType::MAIN_FRAME) { 742 if (info->GetResourceType() == ResourceType::MAIN_FRAME) {
742 // This enumeration has "3" appended to its name to distinguish it from 743 // This enumeration has "3" appended to its name to distinguish it from
743 // older versions. 744 // older versions.
744 UMA_HISTOGRAM_CUSTOM_ENUMERATION( 745 UMA_HISTOGRAM_SPARSE_SLOWLY(
745 "Net.ErrorCodesForMainFrame3", 746 "Net.ErrorCodesForMainFrame3",
746 -loader->request()->status().error(), 747 -loader->request()->status().error());
747 base::CustomHistogram::ArrayToCustomRanges(
748 kAllNetErrorCodes, arraysize(kAllNetErrorCodes)));
749 748
750 if (loader->request()->url().SchemeIsSecure() && 749 if (loader->request()->url().SchemeIsSecure() &&
751 loader->request()->url().host() == "www.google.com") { 750 loader->request()->url().host() == "www.google.com") {
752 UMA_HISTOGRAM_CUSTOM_ENUMERATION( 751 UMA_HISTOGRAM_SPARSE_SLOWLY(
753 "Net.ErrorCodesForHTTPSGoogleMainFrame2", 752 "Net.ErrorCodesForHTTPSGoogleMainFrame2",
754 -loader->request()->status().error(), 753 -loader->request()->status().error());
755 base::CustomHistogram::ArrayToCustomRanges(
756 kAllNetErrorCodes, arraysize(kAllNetErrorCodes)));
757 } 754 }
758 } else { 755 } else {
756 if (info->GetResourceType() == ResourceType::IMAGE) {
757 UMA_HISTOGRAM_SPARSE_SLOWLY(
758 "Net.ErrorCodesForImages",
759 -loader->request()->status().error());
760 }
759 // This enumeration has "2" appended to distinguish it from older versions. 761 // This enumeration has "2" appended to distinguish it from older versions.
760 UMA_HISTOGRAM_CUSTOM_ENUMERATION( 762 UMA_HISTOGRAM_SPARSE_SLOWLY(
761 "Net.ErrorCodesForSubresources2", 763 "Net.ErrorCodesForSubresources2",
762 -loader->request()->status().error(), 764 -loader->request()->status().error());
763 base::CustomHistogram::ArrayToCustomRanges(
764 kAllNetErrorCodes, arraysize(kAllNetErrorCodes)));
765 } 765 }
766 766
767 // Destroy the ResourceLoader. 767 // Destroy the ResourceLoader.
768 RemovePendingRequest(info->GetChildID(), info->GetRequestID()); 768 RemovePendingRequest(info->GetChildID(), info->GetRequestID());
769 } 769 }
770 770
771 // static 771 // static
772 bool ResourceDispatcherHostImpl::RenderViewForRequest( 772 bool ResourceDispatcherHostImpl::RenderViewForRequest(
773 const net::URLRequest* request, 773 const net::URLRequest* request,
774 int* render_process_id, 774 int* render_process_id,
(...skipping 1016 matching lines...) Expand 10 before | Expand all | Expand 10 after
1791 DelegateMap::iterator it = delegate_map_.find(id); 1791 DelegateMap::iterator it = delegate_map_.find(id);
1792 DCHECK(it->second->HasObserver(delegate)); 1792 DCHECK(it->second->HasObserver(delegate));
1793 it->second->RemoveObserver(delegate); 1793 it->second->RemoveObserver(delegate);
1794 if (it->second->size() == 0) { 1794 if (it->second->size() == 0) {
1795 delete it->second; 1795 delete it->second;
1796 delegate_map_.erase(it); 1796 delegate_map_.erase(it);
1797 } 1797 }
1798 } 1798 }
1799 1799
1800 } // namespace content 1800 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698