Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 14093002: Shader optimization for ovals (Closed)

Created:
7 years, 8 months ago by jvanverth1
Modified:
7 years, 8 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Shader optimization for ovals. Previously we were setting a center point as an attribute across all vertices, then using that with the interpolated position to compute an offset. However, because the offset computation is linear, we can just set the appropriate offset at the vertices and let the rasterizer interpolate it for us. Committed: http://code.google.com/p/skia/source/detail?r=8613

Patch Set 1 #

Patch Set 2 : Add bounds to drawNonIndexed, some cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -57 lines) Patch
M src/gpu/GrOvalRenderer.cpp View 1 8 chunks +74 lines, -57 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
jvanverth1
7 years, 8 months ago (2013-04-10 21:53:19 UTC) #1
robertphillips
lgtm - could you paste the performance numbers here? https://codereview.chromium.org/14093002/diff/2001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/14093002/diff/2001/src/gpu/GrOvalRenderer.cpp#newcode539 src/gpu/GrOvalRenderer.cpp:539: ...
7 years, 8 months ago (2013-04-10 23:18:39 UTC) #2
jvanverth1
Here are the perf numbers on Mac OS. I'm not sure why ovals_1 and ovals_3 ...
7 years, 8 months ago (2013-04-11 14:16:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/14093002/2001
7 years, 8 months ago (2013-04-11 14:26:00 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-11 15:05:39 UTC) #5
Message was sent while issue was closed.
Change committed as 8613

Powered by Google App Engine
This is Rietveld 408576698