Add compositor support for the LatencyInfo.

Add compositor support for the LatencyInfo.

This just passes it through from the main thread to the impl thread upon commit (and then to the renderer).

BUG=155367
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195433

[jbauman, 2013-04-16 18:11:54]

This should add just enough plumbing so that this is useful with input events
(on non-impl-side-painting platforms).

[jamesr, 2013-04-17 23:15:20]

https://codereview.chromium.org/14092003/diff/3001/cc/output/delegating_rende...
File cc/output/delegating_renderer.cc (right):

https://codereview.chromium.org/14092003/diff/3001/cc/output/delegating_rende...
cc/output/delegating_renderer.cc:165: bool DelegatingRenderer::SwapBuffers(const
LatencyInfo&) {
in chromium style, you want to include the variable name regardless of if it's
used

https://codereview.chromium.org/14092003/diff/3001/cc/trees/layer_tree_host.cc
File cc/trees/layer_tree_host.cc (right):

https://codereview.chromium.org/14092003/diff/3001/cc/trees/layer_tree_host.c...
cc/trees/layer_tree_host.cc:256: host_impl->SetLatencyInfo(latency_info_);
To make this work in impl-side painting you want to associate the latency
information with a LayerTreeImpl, not with a LayerTreeHostImpl.  Impl-side
painting works by doing this:

LayerTreeHost pushes info to the LayerTreeHostImpl::pending_tree_, which is a
LayerTreeImpl
then when the pending tree has rasterized enough
LayerTreeHostImpl pushes the pending_tree_ into its active_tree_

LayerTreeHostImpl always draws (swaps) from its active_tree_.

I think it's easy enough to put this information on the LayerTreeImpl from the
start, so can we do that in this patch?  See the 'sync_tree_' in
FinishCommitOnImplThread() below

[jbauman, 2013-04-18 01:22:27]

Thanks for the explanation. I've added support for impl-side painting now.

On 2013/04/17 23:15:20, jamesr wrote:
>
https://codereview.chromium.org/14092003/diff/3001/cc/output/delegating_rende...
> File cc/output/delegating_renderer.cc (right):
> 
>
https://codereview.chromium.org/14092003/diff/3001/cc/output/delegating_rende...
> cc/output/delegating_renderer.cc:165: bool
DelegatingRenderer::SwapBuffers(const
> LatencyInfo&) {
> in chromium style, you want to include the variable name regardless of if it's
> used
> 
> https://codereview.chromium.org/14092003/diff/3001/cc/trees/layer_tree_host.cc
> File cc/trees/layer_tree_host.cc (right):
> 
>
https://codereview.chromium.org/14092003/diff/3001/cc/trees/layer_tree_host.c...
> cc/trees/layer_tree_host.cc:256: host_impl->SetLatencyInfo(latency_info_);
> To make this work in impl-side painting you want to associate the latency
> information with a LayerTreeImpl, not with a LayerTreeHostImpl.  Impl-side
> painting works by doing this:
> 
> LayerTreeHost pushes info to the LayerTreeHostImpl::pending_tree_, which is a
> LayerTreeImpl
> then when the pending tree has rasterized enough
> LayerTreeHostImpl pushes the pending_tree_ into its active_tree_
> 
> LayerTreeHostImpl always draws (swaps) from its active_tree_.
> 
> I think it's easy enough to put this information on the LayerTreeImpl from the
> start, so can we do that in this patch?  See the 'sync_tree_' in
> FinishCommitOnImplThread() below

[jamesr, 2013-04-19 01:25:38]

lgtm

https://codereview.chromium.org/14092003/diff/10001/cc/output/software_render...
File cc/output/software_renderer.cc (right):

https://codereview.chromium.org/14092003/diff/10001/cc/output/software_render...
cc/output/software_renderer.cc:120: bool SoftwareRenderer::SwapBuffers(const
cc::LatencyInfo&) {
no cc:: needed, you're inside the namespace

https://codereview.chromium.org/14092003/diff/10001/cc/trees/layer_tree_host_...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/14092003/diff/10001/cc/trees/layer_tree_host_...
cc/trees/layer_tree_host_impl.cc:1125: active_tree_->ClearLatencyInfo();
do we want to clear the latency info if the swap failed?

actually, can this actually fail? why's it a bool?

[jbauman, 2013-04-19 18:36:24]

On 2013/04/19 01:25:38, jamesr wrote:
> lgtm
> 
>
https://codereview.chromium.org/14092003/diff/10001/cc/output/software_render...
> File cc/output/software_renderer.cc (right):
> 
>
https://codereview.chromium.org/14092003/diff/10001/cc/output/software_render...
> cc/output/software_renderer.cc:120: bool SoftwareRenderer::SwapBuffers(const
> cc::LatencyInfo&) {
> no cc:: needed, you're inside the namespace
> 
>
https://codereview.chromium.org/14092003/diff/10001/cc/trees/layer_tree_host_...
> File cc/trees/layer_tree_host_impl.cc (right):
> 
>
https://codereview.chromium.org/14092003/diff/10001/cc/trees/layer_tree_host_...
> cc/trees/layer_tree_host_impl.cc:1125: active_tree_->ClearLatencyInfo();
> do we want to clear the latency info if the swap failed?
> 
> actually, can this actually fail? why's it a bool?

Doesn't look like any of the current implementations can actually fail. Do you
want me to change it to void?

[jamesr, 2013-04-19 19:46:22]

On 2013/04/19 18:36:24, jbauman wrote:
> Doesn't look like any of the current implementations can actually fail. Do you
> want me to change it to void?

That would be great!  You don't have to do it in this patch.

[commit-bot: I haz the power, 2013-04-19 22:46:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/14092003/19001

[commit-bot: I haz the power, 2013-04-19 23:51:42]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-04-20 00:08:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/14092003/19001

[commit-bot: I haz the power, 2013-04-20 02:13:05]

Retried try job too often on win_x64_rel for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...

[commit-bot: I haz the power, 2013-04-20 02:22:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/14092003/19001

[commit-bot: I haz the power, 2013-04-20 02:39:20]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-22 00:42:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/14092003/19001

[commit-bot: I haz the power, 2013-04-22 02:28:41]

Change committed as 195433