Move MockUpdateEngineClient::GetLastStatus() expectation to MockDBusThreadManager's ctor

Move MockUpdateEngineClient::GetLastStatus() expectation to MockDBusThreadManager's ctor

This removes the code dup in those CrOS browsertests which are using
MockDBusThreadManager.

BUG=None.
TEST=browsertests pass, unittests pass.
TBR=mnissler

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193566

[Daniel Erat, 2013-04-10 20:06:00]

lgtm

Thanks!

https://codereview.chromium.org/14092002/diff/3001/chromeos/dbus/mock_dbus_th...
File chromeos/dbus/mock_dbus_thread_manager.cc (right):

https://codereview.chromium.org/14092002/diff/3001/chromeos/dbus/mock_dbus_th...
chromeos/dbus/mock_dbus_thread_manager.cc:281: .Times(AnyNumber())
nit: is this .Times(AnyNumber()) necessary?  i think you may be able to leave it
out -- i'd expect WillRepeatedly() to imply it

[Daniel Erat, 2013-04-10 20:07:34]

Oh, and you don't need to re-upload your patch to change the commit message in
rietveld (codereview.chromium.org) -- the "Edit Issue" link lets you change it.

[Yufeng Shen (Slow to review), 2013-04-10 20:29:21]

cc sky@ for OWNERS

https://codereview.chromium.org/14092002/diff/3001/chromeos/dbus/mock_dbus_th...
File chromeos/dbus/mock_dbus_thread_manager.cc (right):

https://codereview.chromium.org/14092002/diff/3001/chromeos/dbus/mock_dbus_th...
chromeos/dbus/mock_dbus_thread_manager.cc:281: .Times(AnyNumber())
On 2013/04/10 20:06:00, Daniel Erat wrote:
> nit: is this .Times(AnyNumber()) necessary?  i think you may be able to leave
it
> out -- i'd expect WillRepeatedly() to imply it

Done.

[sky, 2013-04-10 21:21:37]

What do you need me to review?

[commit-bot: I haz the power, 2013-04-10 21:45:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miletus@chromium.org/14092002/5001

[commit-bot: I haz the power, 2013-04-10 21:45:46]

Presubmit check for 14092002-5001 failed and returned exit status 1.

INFO:root:Found 8 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/policy/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

Presubmit checks took 1.1s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2013-04-10 21:47:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miletus@chromium.org/14092002/5001

[commit-bot: I haz the power, 2013-04-11 02:30:03]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-04-11 03:13:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miletus@chromium.org/14092002/5001

[commit-bot: I haz the power, 2013-04-11 04:17:04]

Change committed as 193566