ui/views/controls/button/menu_button.h - Issue 1409183003: Adds ripple animation to extension buttons on a toolbar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/menu_button.h

Issue 1409183003: Adds ripple animation to extension buttons on a toolbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adds ripple animation to extension buttons on a toolbar (fix for bug 546683) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_action_view.cc ('k') | ui/views/controls/button/menu_button.cc » ('j') | ui/views/controls/button/menu_button.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/button/menu_button.h

diff --git a/ui/views/controls/button/menu_button.h b/ui/views/controls/button/menu_button.h

index 1881fd2412ceecf9a8c0a958a3e9e7cd8edf2029..3b87753979a28f50e2067f9631f504985d2a3efe 100644

--- a/ui/views/controls/button/menu_button.h

+++ b/ui/views/controls/button/menu_button.h

@@ -64,6 +64,9 @@ class VIEWS_EXPORT MenuButton : public LabelButton {

// Activate the button (called when the button is pressed).

bool Activate();

+ // Called to signal that the action will not be activated.

+ void WillNotActivate();

sadrul 2015/11/18 22:56:31 This is .. confusing. The way it is done now, it o

varkha 2015/11/18 23:27:54 This is inlined in OnMouseReleased (see https://co

// Overridden from View:

gfx::Size GetPreferredSize() const override;

const char* GetClassName() const override;