Adds ripple animation to extension buttons on a toolbar

ui/views/controls/button/menu_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/menu_button.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/dragdrop/drag_drop_types.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 127 matching lines @@
     menu_closed_time_ = TimeTicks::Now();
 
     // We must return false here so that the RootView does not get stuck
     // sending all mouse pressed events to us instead of the appropriate
     // target.
     return false;
   }
   return true;
 }
 
+void MenuButton::WillNotActivate() {
+  if (listener_) {
+    listener_->OnMenuButtonClickCanceled(this);

[sadrul, 2015/11/18 22:56:31]

no {} for this

[varkha, 2015/11/18 23:27:54]

This is inlined in OnMouseReleased (see
https://codereview.chromium.org/1411833006/).

+  }
+}
+
 void MenuButton::OnPaint(gfx::Canvas* canvas) {
   LabelButton::OnPaint(canvas);
 
   if (show_menu_marker_)
     PaintMenuMarker(canvas);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // MenuButton - Events
@@ skipping 24 matching lines @@
       return Activate();
   }
   return true;
 }
 
 void MenuButton::OnMouseReleased(const ui::MouseEvent& event) {
   if (state() != STATE_DISABLED && ShouldEnterPushedState(event) &&
       HitTestPoint(event.location()) && !InDrag()) {
     Activate();
   } else {
+    WillNotActivate();

[sadrul, 2015/11/18 22:56:31]

Can this directly call into listener_->OnMenuButtonClickCanceled()?

[varkha, 2015/11/18 23:27:54]

Done in https://codereview.chromium.org/1411833006/.

     LabelButton::OnMouseReleased(event);
   }
 }
 
 void MenuButton::OnMouseEntered(const ui::MouseEvent& event) {
   if (pressed_lock_count_ == 0)  // Ignore mouse movement if state is locked.
     LabelButton::OnMouseEntered(event);
 }
 
 void MenuButton::OnMouseExited(const ui::MouseEvent& event) {
@@ skipping 153 matching lines @@
   if (!GetWidget()) {
     NOTREACHED();
     return 0;
   }
 
   gfx::Rect monitor_bounds = GetWidget()->GetWorkAreaBoundsInScreen();
   return monitor_bounds.right() - 1;
 }
 
 }  // namespace views