Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Side by Side Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

Issue 1409183003: Adds ripple animation to extension buttons on a toolbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds ripple animation to extension buttons on a toolbar (fix for bug 546683) Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/toolbar/toolbar_action_view.h" 5 #include "chrome/browser/ui/views/toolbar/toolbar_action_view.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "chrome/browser/chrome_notification_types.h" 10 #include "chrome/browser/chrome_notification_types.h"
11 #include "chrome/browser/profiles/profile.h" 11 #include "chrome/browser/profiles/profile.h"
12 #include "chrome/browser/sessions/session_tab_helper.h" 12 #include "chrome/browser/sessions/session_tab_helper.h"
13 #include "chrome/browser/themes/theme_service.h" 13 #include "chrome/browser/themes/theme_service.h"
14 #include "chrome/browser/themes/theme_service_factory.h" 14 #include "chrome/browser/themes/theme_service_factory.h"
15 #include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h" 15 #include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h"
16 #include "chrome/browser/ui/toolbar/toolbar_actions_bar.h" 16 #include "chrome/browser/ui/toolbar/toolbar_actions_bar.h"
17 #include "chrome/browser/ui/view_ids.h" 17 #include "chrome/browser/ui/view_ids.h"
18 #include "chrome/grit/generated_resources.h" 18 #include "chrome/grit/generated_resources.h"
19 #include "content/public/browser/notification_source.h" 19 #include "content/public/browser/notification_source.h"
20 #include "grit/theme_resources.h" 20 #include "grit/theme_resources.h"
21 #include "ui/accessibility/ax_view_state.h" 21 #include "ui/accessibility/ax_view_state.h"
22 #include "ui/base/resource/resource_bundle.h" 22 #include "ui/base/resource/resource_bundle.h"
23 #include "ui/compositor/paint_recorder.h" 23 #include "ui/compositor/paint_recorder.h"
24 #include "ui/events/event.h" 24 #include "ui/events/event.h"
25 #include "ui/gfx/image/image_skia.h" 25 #include "ui/gfx/image/image_skia.h"
26 #include "ui/gfx/image/image_skia_operations.h" 26 #include "ui/gfx/image/image_skia_operations.h"
27 #include "ui/gfx/image/image_skia_source.h" 27 #include "ui/gfx/image/image_skia_source.h"
28 #include "ui/resources/grit/ui_resources.h" 28 #include "ui/resources/grit/ui_resources.h"
29 #include "ui/views/animation/ink_drop_animation_controller.h"
30 #include "ui/views/animation/ink_drop_animation_controller_factory.h"
29 #include "ui/views/controls/button/label_button_border.h" 31 #include "ui/views/controls/button/label_button_border.h"
30 #include "ui/views/controls/menu/menu_controller.h" 32 #include "ui/views/controls/menu/menu_controller.h"
31 #include "ui/views/controls/menu/menu_model_adapter.h" 33 #include "ui/views/controls/menu/menu_model_adapter.h"
32 #include "ui/views/controls/menu/menu_runner.h" 34 #include "ui/views/controls/menu/menu_runner.h"
33 #include "ui/views/mouse_constants.h" 35 #include "ui/views/mouse_constants.h"
34 #include "ui/views/resources/grit/views_resources.h" 36 #include "ui/views/resources/grit/views_resources.h"
35 37
36 using views::LabelButtonBorder; 38 using views::LabelButtonBorder;
37 39
38 namespace { 40 namespace {
(...skipping 20 matching lines...) Expand all
59 ToolbarActionViewController* view_controller, 61 ToolbarActionViewController* view_controller,
60 Profile* profile, 62 Profile* profile,
61 ToolbarActionView::Delegate* delegate) 63 ToolbarActionView::Delegate* delegate)
62 : MenuButton(nullptr, base::string16(), this, false), 64 : MenuButton(nullptr, base::string16(), this, false),
63 view_controller_(view_controller), 65 view_controller_(view_controller),
64 profile_(profile), 66 profile_(profile),
65 delegate_(delegate), 67 delegate_(delegate),
66 called_register_command_(false), 68 called_register_command_(false),
67 wants_to_run_(false), 69 wants_to_run_(false),
68 menu_(nullptr), 70 menu_(nullptr),
71 ink_drop_animation_controller_(
72 views::InkDropAnimationControllerFactory::
73 CreateInkDropAnimationController(this)),
69 weak_factory_(this) { 74 weak_factory_(this) {
70 set_id(VIEW_ID_BROWSER_ACTION); 75 set_id(VIEW_ID_BROWSER_ACTION);
71 view_controller_->SetDelegate(this); 76 view_controller_->SetDelegate(this);
72 SetHorizontalAlignment(gfx::ALIGN_CENTER); 77 SetHorizontalAlignment(gfx::ALIGN_CENTER);
73 set_drag_controller(delegate_); 78 set_drag_controller(delegate_);
74 79
75 set_context_menu_controller(this); 80 set_context_menu_controller(this);
76 81
82 const int kInkDropLargeSize = 32;
83 const int kInkDropLargeCornerRadius = 5;
84 const int kInkDropSmallSize = 24;
85 const int kInkDropSmallCornerRadius = 2;
86
87 ink_drop_animation_controller_->SetInkDropSize(
88 gfx::Size(kInkDropLargeSize, kInkDropLargeSize),
89 kInkDropLargeCornerRadius,
90 gfx::Size(kInkDropSmallSize, kInkDropSmallSize),
91 kInkDropSmallCornerRadius);
92
77 // We also listen for browser theme changes on linux because a switch from or 93 // We also listen for browser theme changes on linux because a switch from or
78 // to GTK requires that we regrab our browser action images. 94 // to GTK requires that we regrab our browser action images.
79 registrar_.Add( 95 registrar_.Add(
80 this, 96 this,
81 chrome::NOTIFICATION_BROWSER_THEME_CHANGED, 97 chrome::NOTIFICATION_BROWSER_THEME_CHANGED,
82 content::Source<ThemeService>( 98 content::Source<ThemeService>(
83 ThemeServiceFactory::GetForProfile(profile_))); 99 ThemeServiceFactory::GetForProfile(profile_)));
84 100
85 // If the button is within a menu, we need to make it focusable in order to 101 // If the button is within a menu, we need to make it focusable in order to
86 // have it accessible via keyboard navigation, but it shouldn't request focus 102 // have it accessible via keyboard navigation, but it shouldn't request focus
87 // (because that would close the menu). 103 // (because that would close the menu).
88 if (delegate_->ShownInsideMenu()) { 104 if (delegate_->ShownInsideMenu()) {
89 set_request_focus_on_press(false); 105 set_request_focus_on_press(false);
90 SetFocusable(true); 106 SetFocusable(true);
91 } 107 }
92 108
93 UpdateState(); 109 UpdateState();
94 } 110 }
95 111
96 ToolbarActionView::~ToolbarActionView() { 112 ToolbarActionView::~ToolbarActionView() {
97 if (context_menu_owner == this) 113 if (context_menu_owner == this)
98 context_menu_owner = nullptr; 114 context_menu_owner = nullptr;
99 view_controller_->SetDelegate(nullptr); 115 view_controller_->SetDelegate(nullptr);
100 } 116 }
101 117
118 void ToolbarActionView::AddInkDropLayer(ui::Layer* ink_drop_layer) {
119 SetPaintToLayer(true);
120 SetFillsBoundsOpaquely(false);
121 image()->SetPaintToLayer(true);
122 image()->SetFillsBoundsOpaquely(false);
123
124 layer()->Add(ink_drop_layer);
125 layer()->StackAtBottom(ink_drop_layer);
126 }
127
128 void ToolbarActionView::RemoveInkDropLayer(ui::Layer* ink_drop_layer) {
129 layer()->Remove(ink_drop_layer);
130
131 image()->SetFillsBoundsOpaquely(true);
132 image()->SetPaintToLayer(false);
133 SetPaintToLayer(false);
134 }
135
136 gfx::Point ToolbarActionView::CalculateInkDropCenter() const {
137 return GetLocalBounds().CenterPoint();
138 }
139
102 gfx::Size ToolbarActionView::GetPreferredSize() const { 140 gfx::Size ToolbarActionView::GetPreferredSize() const {
103 return gfx::Size(ToolbarActionsBar::IconWidth(false), 141 return gfx::Size(ToolbarActionsBar::IconWidth(false),
104 ToolbarActionsBar::IconHeight()); 142 ToolbarActionsBar::IconHeight());
105 } 143 }
106 144
145 void ToolbarActionView::Layout() {
146 MenuButton::Layout();
147 ink_drop_animation_controller_->SetInkDropCenter(CalculateInkDropCenter());
148 }
149
150 bool ToolbarActionView::OnMousePressed(const ui::MouseEvent& event) {
151 // views::MenuButton actions are only triggered by left mouse clicks.
152 if (event.IsLeftMouseButton()) {
153 ink_drop_animation_controller_->AnimateToState(
154 views::InkDropState::ACTION_PENDING);
155 }
156 return MenuButton::OnMousePressed(event);
157 }
158
159 void ToolbarActionView::OnGestureEvent(ui::GestureEvent* event) {
160 // TODO(varkha): refactor similar implementations in ToolbarButton,
161 // FindBarButton and here.
162 if (menu_) {
163 // While dropdown menu is showing the button should not handle gestures.
164 event->StopPropagation();
165 return;
166 }
167
168 MenuButton::OnGestureEvent(event);
169
170 views::InkDropState ink_drop_state = views::InkDropState::HIDDEN;
171 switch (event->type()) {
172 case ui::ET_GESTURE_TAP_DOWN:
173 ink_drop_state = views::InkDropState::ACTION_PENDING;
174 // The ui::ET_GESTURE_TAP_DOWN event needs to be marked as handled so that
175 // subsequent events for the gesture are sent to |this|.
176 event->SetHandled();
177 break;
178 case ui::ET_GESTURE_LONG_PRESS:
179 ink_drop_state = views::InkDropState::SLOW_ACTION_PENDING;
180 break;
181 case ui::ET_GESTURE_LONG_TAP:
182 ink_drop_state = views::InkDropState::SLOW_ACTION;
183 break;
184 case ui::ET_GESTURE_SCROLL_BEGIN:
185 case ui::ET_GESTURE_END:
186 ink_drop_state = views::InkDropState::HIDDEN;
187 break;
188 default:
189 return;
190 }
191
192 views::InkDropState current_ink_drop_state =
193 ink_drop_animation_controller_->GetInkDropState();
194
195 if (ink_drop_state == views::InkDropState::HIDDEN &&
196 (current_ink_drop_state == views::InkDropState::QUICK_ACTION ||
197 current_ink_drop_state == views::InkDropState::SLOW_ACTION ||
198 current_ink_drop_state == views::InkDropState::DEACTIVATED)) {
199 // These InkDropStates automatically transition to the HIDDEN state so we
200 // don't make an explicit call. Explicitly animating to HIDDEN in this case
201 // would prematurely pre-empt these animations.
202 return;
203 }
204 ink_drop_animation_controller_->AnimateToState(ink_drop_state);
205 }
206
107 void ToolbarActionView::OnDragDone() { 207 void ToolbarActionView::OnDragDone() {
208 ink_drop_animation_controller_->AnimateToState(views::InkDropState::HIDDEN);
108 views::MenuButton::OnDragDone(); 209 views::MenuButton::OnDragDone();
109 delegate_->OnToolbarActionViewDragDone(); 210 delegate_->OnToolbarActionViewDragDone();
110 } 211 }
111 212
112 void ToolbarActionView::ViewHierarchyChanged( 213 void ToolbarActionView::ViewHierarchyChanged(
113 const ViewHierarchyChangedDetails& details) { 214 const ViewHierarchyChangedDetails& details) {
114 if (details.is_add && !called_register_command_ && GetFocusManager()) { 215 if (details.is_add && !called_register_command_ && GetFocusManager()) {
115 view_controller_->RegisterCommand(); 216 view_controller_->RegisterCommand();
116 called_register_command_ = true; 217 called_register_command_ = true;
117 } 218 }
118 219
119 MenuButton::ViewHierarchyChanged(details); 220 MenuButton::ViewHierarchyChanged(details);
120 } 221 }
121 222
122 void ToolbarActionView::GetAccessibleState(ui::AXViewState* state) { 223 void ToolbarActionView::GetAccessibleState(ui::AXViewState* state) {
123 views::MenuButton::GetAccessibleState(state); 224 views::MenuButton::GetAccessibleState(state);
124 state->role = ui::AX_ROLE_BUTTON; 225 state->role = ui::AX_ROLE_BUTTON;
125 } 226 }
126 227
127 void ToolbarActionView::OnMenuButtonClicked(views::View* sender, 228 void ToolbarActionView::OnMenuButtonClicked(views::View* sender,
128 const gfx::Point& point) { 229 const gfx::Point& point) {
129 if (!view_controller_->IsEnabled(GetCurrentWebContents())) { 230 if (!view_controller_->IsEnabled(GetCurrentWebContents())) {
130 // We should only get a button pressed event with a non-enabled action if 231 // We should only get a button pressed event with a non-enabled action if
131 // the left-click behavior should open the menu. 232 // the left-click behavior should open the menu.
132 DCHECK(view_controller_->DisabledClickOpensMenu()); 233 DCHECK(view_controller_->DisabledClickOpensMenu());
133 context_menu_controller()->ShowContextMenuForView(this, point, 234 context_menu_controller()->ShowContextMenuForView(this, point,
134 ui::MENU_SOURCE_NONE); 235 ui::MENU_SOURCE_NONE);
135 } else { 236 } else {
237 ink_drop_animation_controller_->AnimateToState(
238 views::InkDropState::QUICK_ACTION);
136 view_controller_->ExecuteAction(true); 239 view_controller_->ExecuteAction(true);
137 } 240 }
138 } 241 }
139 242
243 void ToolbarActionView::OnMenuButtonClickCanceled(views::View* sender) {
244 ink_drop_animation_controller_->AnimateToState(views::InkDropState::HIDDEN);
245 }
246
140 void ToolbarActionView::UpdateState() { 247 void ToolbarActionView::UpdateState() {
141 content::WebContents* web_contents = GetCurrentWebContents(); 248 content::WebContents* web_contents = GetCurrentWebContents();
142 if (SessionTabHelper::IdForTab(web_contents) < 0) 249 if (SessionTabHelper::IdForTab(web_contents) < 0)
143 return; 250 return;
144 251
145 if (!view_controller_->IsEnabled(web_contents) && 252 if (!view_controller_->IsEnabled(web_contents) &&
146 !view_controller_->DisabledClickOpensMenu()) { 253 !view_controller_->DisabledClickOpensMenu()) {
147 SetState(views::CustomButton::STATE_DISABLED); 254 SetState(views::CustomButton::STATE_DISABLED);
148 } else if (state() == views::CustomButton::STATE_DISABLED) { 255 } else if (state() == views::CustomButton::STATE_DISABLED) {
149 SetState(views::CustomButton::STATE_NORMAL); 256 SetState(views::CustomButton::STATE_NORMAL);
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::CONTEXT_MENU; 395 views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::CONTEXT_MENU;
289 if (delegate_->ShownInsideMenu()) 396 if (delegate_->ShownInsideMenu())
290 run_types |= views::MenuRunner::IS_NESTED; 397 run_types |= views::MenuRunner::IS_NESTED;
291 398
292 // RunMenuAt expects a nested menu to be parented by the same widget as the 399 // RunMenuAt expects a nested menu to be parented by the same widget as the
293 // already visible menu, in this case the Chrome menu. 400 // already visible menu, in this case the Chrome menu.
294 views::Widget* parent = delegate_->ShownInsideMenu() ? 401 views::Widget* parent = delegate_->ShownInsideMenu() ?
295 delegate_->GetOverflowReferenceView()->GetWidget() : 402 delegate_->GetOverflowReferenceView()->GetWidget() :
296 GetWidget(); 403 GetWidget();
297 404
405 ink_drop_animation_controller_->AnimateToState(
406 views::InkDropState::ACTIVATED);
407
298 views::MenuModelAdapter adapter(context_menu_model); 408 views::MenuModelAdapter adapter(context_menu_model);
299 menu_ = adapter.CreateMenu(); 409 menu_ = adapter.CreateMenu();
300 menu_runner_.reset(new views::MenuRunner(menu_, run_types)); 410 menu_runner_.reset(new views::MenuRunner(menu_, run_types));
301 411
302 if (context_menu_callback) 412 if (context_menu_callback)
303 context_menu_callback->Run(this); 413 context_menu_callback->Run(this);
304 if (menu_runner_->RunMenuAt(parent, this, gfx::Rect(screen_loc, size()), 414 if (menu_runner_->RunMenuAt(parent, this, gfx::Rect(screen_loc, size()),
305 views::MENU_ANCHOR_TOPLEFT, 415 views::MENU_ANCHOR_TOPLEFT,
306 source_type) == views::MenuRunner::MENU_DELETED) { 416 source_type) == views::MenuRunner::MENU_DELETED) {
417 menu_ = nullptr;
307 return; 418 return;
308 } 419 }
420 ink_drop_animation_controller_->AnimateToState(
421 views::InkDropState::DEACTIVATED);
309 422
310 menu_runner_.reset(); 423 menu_runner_.reset();
311 menu_ = nullptr; 424 menu_ = nullptr;
312 context_menu_owner = nullptr; 425 context_menu_owner = nullptr;
313 view_controller_->OnContextMenuClosed(); 426 view_controller_->OnContextMenuClosed();
314 427
315 // If another extension action wants to show its context menu, allow it to. 428 // If another extension action wants to show its context menu, allow it to.
316 if (!followup_context_menu_task_.is_null()) { 429 if (!followup_context_menu_task_.is_null()) {
317 base::Closure task = followup_context_menu_task_; 430 base::Closure task = followup_context_menu_task_;
318 followup_context_menu_task_ = base::Closure(); 431 followup_context_menu_task_ = base::Closure();
(...skipping 14 matching lines...) Expand all
333 if (menu_controller->in_nested_run()) { 446 if (menu_controller->in_nested_run()) {
334 // There is another menu showing. Close the outermost menu (since we are 447 // There is another menu showing. Close the outermost menu (since we are
335 // shown in the same menu, we don't want to close the whole thing). 448 // shown in the same menu, we don't want to close the whole thing).
336 menu_controller->Cancel(views::MenuController::EXIT_OUTERMOST); 449 menu_controller->Cancel(views::MenuController::EXIT_OUTERMOST);
337 return true; 450 return true;
338 } 451 }
339 } 452 }
340 453
341 return false; 454 return false;
342 } 455 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698