Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 14091013: Add a flag to deoptimize all functions every n garbage collections. (Closed)

Created:
7 years, 8 months ago by ulan
Modified:
7 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Add a flag to deoptimize all functions every n garbage collections. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14395

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/flag-definitions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
Please take a look.
7 years, 8 months ago (2013-04-23 10:49:40 UTC) #1
Michael Starzinger
LGTM with a nit. https://chromiumcodereview.appspot.com/14091013/diff/1/src/heap.h File src/heap.h (right): https://chromiumcodereview.appspot.com/14091013/diff/1/src/heap.h#newcode2302 src/heap.h:2302: nit: Drop one of the ...
7 years, 8 months ago (2013-04-23 15:15:23 UTC) #2
ulan
7 years, 8 months ago (2013-04-23 15:21:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14395 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698