Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1426)

Unified Diff: chrome/browser/chromeos/drive/drive_resource_metadata.h

Issue 14091012: chromeos: Rewrite DriveResourceMetadata::MoveEntryToDirectory with RefreshEntry (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/drive/drive_resource_metadata.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/drive/drive_resource_metadata.h
diff --git a/chrome/browser/chromeos/drive/drive_resource_metadata.h b/chrome/browser/chromeos/drive/drive_resource_metadata.h
index 9924947e13a66ce2ca1fdd1fa312b2b6f1a35629..1334deb8cac2054914469548263233a542d0ef97 100644
--- a/chrome/browser/chromeos/drive/drive_resource_metadata.h
+++ b/chrome/browser/chromeos/drive/drive_resource_metadata.h
@@ -233,7 +233,6 @@ class DriveResourceMetadata {
private:
struct FileMoveResult;
struct GetEntryInfoResult;
- struct GetEntryInfoWithFilePathResult;
struct ReadDirectoryResult;
// Note: Use Destroy() to delete this object.
@@ -273,8 +272,10 @@ class DriveResourceMetadata {
FileMoveResult RemoveEntryOnBlockingPool(const std::string& resource_id);
// Used to implement GetEntryInfoByResourceId().
- scoped_ptr<GetEntryInfoWithFilePathResult>
- GetEntryInfoByResourceIdOnBlockingPool(const std::string& resource_id);
+ FileError GetEntryInfoByResourceIdOnBlockingPool(
+ const std::string& resource_id,
+ base::FilePath* out_file_path,
+ DriveEntryProto* out_entry);
// Used to implement GetEntryInfoByPath().
scoped_ptr<GetEntryInfoResult> GetEntryInfoByPathOnBlockingPool(
@@ -285,8 +286,9 @@ class DriveResourceMetadata {
const base::FilePath& file_path);
// Used to implement RefreshEntry().
- scoped_ptr<GetEntryInfoWithFilePathResult> RefreshEntryOnBlockingPool(
- const DriveEntryProto& entry_proto);
+ FileError RefreshEntryOnBlockingPool(const DriveEntryProto& entry_proto,
+ base::FilePath* out_file_path,
+ DriveEntryProto* out_entry);
// Used to implement RefreshDirectory().
FileMoveResult RefreshDirectoryOnBlockingPool(
« no previous file with comments | « no previous file | chrome/browser/chromeos/drive/drive_resource_metadata.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698