Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1409073009: Prefix CSSInterpolationType subclasses with "CSS" (Closed)

Created:
5 years, 1 month ago by alancutter (OOO until 2018)
Modified:
5 years, 1 month ago
Reviewers:
dstockwell
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_unCSSInterpolationType
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prefix CSSInterpolationType subclasses with "CSS" This is a code clean up patch that renames all subclasses of CSSInterpolationType to be prefixed with "CSS" to better distinguish them from future SVGInterpolationType subclasses. BUG=530436 Committed: https://crrev.com/e67124d3498569f8a1ceafffbdcce325d15389a8 Cr-Commit-Position: refs/heads/master@{#356512}

Patch Set 1 #

Patch Set 2 : CSSNIVs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -1754 lines) Patch
A + third_party/WebKit/Source/core/animation/CSSColorInterpolationType.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp View 9 chunks +13 lines, -13 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSImageInterpolationType.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp View 8 chunks +34 lines, -34 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp View 8 chunks +16 lines, -16 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp View 12 chunks +30 lines, -30 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp View 3 chunks +14 lines, -14 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
D third_party/WebKit/Source/core/animation/ColorInterpolationType.h View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/Source/core/animation/ColorInterpolationType.cpp View 1 chunk +0 lines, -231 lines 0 comments Download
D third_party/WebKit/Source/core/animation/ImageInterpolationType.h View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/core/animation/ImageInterpolationType.cpp View 1 chunk +0 lines, -227 lines 0 comments Download
D third_party/WebKit/Source/core/animation/ImageListInterpolationType.h View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/Source/core/animation/ImageListInterpolationType.cpp View 1 chunk +0 lines, -172 lines 0 comments Download
D third_party/WebKit/Source/core/animation/LengthInterpolationType.h View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/core/animation/LengthInterpolationType.cpp View 1 chunk +0 lines, -317 lines 0 comments Download
D third_party/WebKit/Source/core/animation/NumberInterpolationType.h View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/Source/core/animation/NumberInterpolationType.cpp View 1 chunk +0 lines, -93 lines 0 comments Download
D third_party/WebKit/Source/core/animation/PaintInterpolationType.h View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/Source/core/animation/PaintInterpolationType.cpp View 1 chunk +0 lines, -104 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ShadowInterpolationFunctions.cpp View 4 chunks +16 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/core/animation/ShadowListInterpolationType.h View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/core/animation/ShadowListInterpolationType.cpp View 1 chunk +0 lines, -142 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 5 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 6 chunks +15 lines, -14 lines 0 comments Download

Depends on Patchset:

Issue 1394343003 Patch 100001

Messages

Total messages: 7 (2 generated)
alancutter (OOO until 2018)
5 years, 1 month ago (2015-10-26 01:11:22 UTC) #2
dstockwell
lgtm
5 years, 1 month ago (2015-10-27 06:54:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409073009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409073009/20001
5 years, 1 month ago (2015-10-28 03:13:34 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-28 04:32:27 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 04:33:22 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e67124d3498569f8a1ceafffbdcce325d15389a8
Cr-Commit-Position: refs/heads/master@{#356512}

Powered by Google App Engine
This is Rietveld 408576698