Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 14089011: Roll the DEPS for google-url. (Closed)

Created:
7 years, 8 months ago by tfarina
Modified:
7 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, feature-media-reviews_chromium.org, sadrul, akalin, Raghu Simha, ben+watch_chromium.org, grt+watch_chromium.org, amit, jam, cbentzel+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, robertshield, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, haitaol1, tim (not reviewing)
Visibility:
Public.

Description

Roll the DEPS for google-url. And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp. This also changes googleurl.gyp to reference the files under url/, so that we don't break the Blink tree. BUG=229660 R=brettw@chromium.org TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193968

Patch Set 1 #

Patch Set 2 : make googleurl a none target - fix android? #

Patch Set 3 : forward googleurl_unittests - target none - fix? #

Patch Set 4 : url.gyp:googleurl_unittests for now - that is necessary for buildbots #

Patch Set 5 : no need to forward in temp_gyp #

Total comments: 4

Patch Set 6 : sort chrome_tests.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -181 lines) Patch
M DEPS View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ash/ash.gyp View 4 chunks +5 lines, -5 lines 0 comments Download
M build/all.gyp View 1 2 3 9 chunks +10 lines, -10 lines 0 comments Download
M build/temp_gyp/googleurl.gyp View 1 3 4 2 chunks +4 lines, -92 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui_views.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 5 chunks +10 lines, -10 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 6 chunks +10 lines, -10 lines 0 comments Download
M cloud_print/service/service.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill.gypi View 3 chunks +2 lines, -2 lines 0 comments Download
M components/visitedlink.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M jingle/jingle.gyp View 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 10 chunks +10 lines, -10 lines 0 comments Download
M net/tools/tld_cleanup/tld_cleanup.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_internal.gyp View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing.gyp View 1 chunk +1 line, -1 line 0 comments Download
M rlz/rlz.gyp View 1 chunk +1 line, -1 line 0 comments Download
M sync/sync_core.gypi View 1 chunk +1 line, -1 line 0 comments Download
M sync/sync_internal_api.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/message_center.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/oak/oak.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui_unittests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/webview/webview.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views.gyp View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M url/url.gyp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/base/webkit_base.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkit_glue.gypi View 2 chunks +1 line, -1 line 0 comments Download
M webkit/storage/webkit_storage.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M win8/metro_driver/metro_driver.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
tfarina
Let's see what the trybots has to say about this.
7 years, 8 months ago (2013-04-12 00:07:27 UTC) #1
tfarina
Brett, looks like with patch set 5 we are good and read to go. Please, ...
7 years, 8 months ago (2013-04-12 01:49:17 UTC) #2
tfarina
On 2013/04/12 01:49:17, tfarina wrote: > Brett, looks like with patch set 5 we are ...
7 years, 8 months ago (2013-04-12 01:49:34 UTC) #3
brettw
lgtm https://codereview.chromium.org/14089011/diff/15001/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/14089011/diff/15001/chrome/chrome_tests.gypi#newcode3102 chrome/chrome_tests.gypi:3102: '../url/url.gyp:googleurl_unittests', This one isn't in order. https://codereview.chromium.org/14089011/diff/15001/url/url.gyp File ...
7 years, 8 months ago (2013-04-12 04:37:43 UTC) #4
tfarina
https://codereview.chromium.org/14089011/diff/15001/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/14089011/diff/15001/chrome/chrome_tests.gypi#newcode3102 chrome/chrome_tests.gypi:3102: '../url/url.gyp:googleurl_unittests', On 2013/04/12 04:37:44, brettw wrote: > This one ...
7 years, 8 months ago (2013-04-12 14:07:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/14089011/25001
7 years, 8 months ago (2013-04-12 14:30:41 UTC) #6
commit-bot: I haz the power
Presubmit check for 14089011-25001 failed and returned exit status 1. INFO:root:Found 39 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-12 14:30:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/14089011/25001
7 years, 8 months ago (2013-04-12 14:32:05 UTC) #8
commit-bot: I haz the power
Retried try job too often on ios_rel_device for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device&number=40597
7 years, 8 months ago (2013-04-12 15:10:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/14089011/25001
7 years, 8 months ago (2013-04-12 15:52:48 UTC) #10
commit-bot: I haz the power
Retried try job too often on ios_rel_device for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device&number=40611
7 years, 8 months ago (2013-04-12 16:30:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/14089011/25001
7 years, 8 months ago (2013-04-12 16:48:21 UTC) #12
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, compile, content_unittests, crypto_unittests, googleurl_unittests, media_unittests, ...
7 years, 8 months ago (2013-04-12 17:30:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/14089011/25001
7 years, 8 months ago (2013-04-12 17:31:49 UTC) #14
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, compile, content_unittests, crypto_unittests, googleurl_unittests, media_unittests, ...
7 years, 8 months ago (2013-04-12 18:10:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/14089011/25001
7 years, 8 months ago (2013-04-12 18:19:19 UTC) #16
commit-bot: I haz the power
7 years, 8 months ago (2013-04-12 18:29:56 UTC) #17
Message was sent while issue was closed.
Change committed as 193968

Powered by Google App Engine
This is Rietveld 408576698