media: Remove BrowserCdmFactory inferface.

media: Remove BrowserCdmFactory inferface.

BrowserCdmFactory interface was introduced as the browser side factory to create
BrowserCdm. Now BrowserCdm has been merged into MediaKeys interface, this CL
merges BrowserCdmFactory into the more generic CdmFactory interface.

This CL also changes how BrowserCdmFactory is registered/created on Android and
on Cast.

With this CL, we use the same AndroidCdmFactory to create MediaDrmBridge when
it is hosted:
- in the browser process using BrowserCdmManager, or
- in the GPU process using MojoCdmService.

BUG=521731
TEST=Tested MediaDrmBridge creation in the browser and GPU process on Android.

Committed: https://crrev.com/fac3c5e704ff0f2ab04982d372fc70e419a41da0
Cr-Commit-Position: refs/heads/master@{#358390}

[xhwang, 2015-11-05 06:39:50]

Patchset #2 (id:20001) has been deleted

[xhwang, 2015-11-05 06:42:06]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 06:42:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408793009/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408793009/40001

[xhwang, 2015-11-05 06:58:45]

Description was changed from

==========
media: Remove BrowserCdmFactory inferface.

BrowserCdmFactory interface existed as the browser side CDM factory to created
BrowserCdm. Now BrowserCdm has been mreged into MediaKeys interface, this CL
also merges BrowserCdmFactory into the more generic CdmFactory interface.

This CL also changes how BrowserCdmFactory is registered/created on Android and
on Cast.

Also with CL, we use the same AndroidCdmFactory to create MediaDrmBridge when
MediaDrmBridge is hosted:
- in the browser process using BrowserCdmManager, or
- in the GPU process using MojoCdmService.

BUG=521731
TEST=No functionality change.
==========

to

==========
media: Remove BrowserCdmFactory inferface.

BrowserCdmFactory interface existed as the browser side CDM factory to created
BrowserCdm. Now BrowserCdm has been mreged into MediaKeys interface, this CL
also merges BrowserCdmFactory into the more generic CdmFactory interface.

This CL also changes how BrowserCdmFactory is registered/created on Android and
on Cast.

Also with CL, we use the same AndroidCdmFactory to create MediaDrmBridge when
MediaDrmBridge is hosted:
- in the browser process using BrowserCdmManager, or
- in the GPU process using MojoCdmService.

BUG=521731
TEST=Tested MediaDrmBridge creation in the browser and GPU process on Android.
==========

[xhwang, 2015-11-05 06:58:45]

xhwang@chromium.org changed reviewers:
+ halliwell@chromium.org, jrummell@chromium.org

[xhwang, 2015-11-05 07:06:02]

In PS1 I copied browser_cdm_factory_android.cc to android_cdm_factory.cc for
easier diff. PS2 has the real change. Please see the diff between PS1 and PS2
for the best reviewing experience :)

halliwell: Please OWNERS review chromecast changes, especially how the
CdmFactory is registered. I don't know how to test chromecast. Please help make
sure this change is working for chromecast on Android and non-Android.

jrummell: Please review everything.

timav / ddorwin: FYI. With this CL I can successfully create MediaDrmBridge in
the GPU process. It may not work because the http request for provisioning is
still handled in Java. This path is behind compile flags so we should be okay.
timav@ will fix the http issue soon.

[commit-bot: I haz the power, 2015-11-05 07:38:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 07:38:19]

Dry run: This issue passed the CQ dry run.

[xhwang, 2015-11-05 07:56:44]

Description was changed from

==========
media: Remove BrowserCdmFactory inferface.

BrowserCdmFactory interface existed as the browser side CDM factory to created
BrowserCdm. Now BrowserCdm has been mreged into MediaKeys interface, this CL
also merges BrowserCdmFactory into the more generic CdmFactory interface.

This CL also changes how BrowserCdmFactory is registered/created on Android and
on Cast.

Also with CL, we use the same AndroidCdmFactory to create MediaDrmBridge when
MediaDrmBridge is hosted:
- in the browser process using BrowserCdmManager, or
- in the GPU process using MojoCdmService.

BUG=521731
TEST=Tested MediaDrmBridge creation in the browser and GPU process on Android.
==========

to

==========
media: Remove BrowserCdmFactory inferface.

BrowserCdmFactory interface was introduced as the browser side factory to create
BrowserCdm. Now BrowserCdm has been mreged into MediaKeys interface, this CL
also merges BrowserCdmFactory into the more generic CdmFactory interface.

This CL also changes how BrowserCdmFactory is registered/created on Android and
on Cast.

Also with CL, we use the same AndroidCdmFactory to create MediaDrmBridge when
MediaDrmBridge is hosted:
- in the browser process using BrowserCdmManager, or
- in the GPU process using MojoCdmService.

BUG=521731
TEST=Tested MediaDrmBridge creation in the browser and GPU process on Android.
==========

[xhwang, 2015-11-05 07:57:52]

Description was changed from

==========
media: Remove BrowserCdmFactory inferface.

BrowserCdmFactory interface was introduced as the browser side factory to create
BrowserCdm. Now BrowserCdm has been mreged into MediaKeys interface, this CL
also merges BrowserCdmFactory into the more generic CdmFactory interface.

This CL also changes how BrowserCdmFactory is registered/created on Android and
on Cast.

Also with CL, we use the same AndroidCdmFactory to create MediaDrmBridge when
MediaDrmBridge is hosted:
- in the browser process using BrowserCdmManager, or
- in the GPU process using MojoCdmService.

BUG=521731
TEST=Tested MediaDrmBridge creation in the browser and GPU process on Android.
==========

to

==========
media: Remove BrowserCdmFactory inferface.

BrowserCdmFactory interface was introduced as the browser side factory to create
BrowserCdm. Now BrowserCdm has been mreged into MediaKeys interface, this CL
merges BrowserCdmFactory into the more generic CdmFactory interface.

This CL also changes how BrowserCdmFactory is registered/created on Android and
on Cast.

With this CL, we use the same AndroidCdmFactory to create MediaDrmBridge when
it is hosted:
- in the browser process using BrowserCdmManager, or
- in the GPU process using MojoCdmService.

BUG=521731
TEST=Tested MediaDrmBridge creation in the browser and GPU process on Android.
==========

[jrummell, 2015-11-05 21:27:41]

s/mreged/merged/ in the description.

Other than that, lgtm.

[halliwell, 2015-11-05 22:20:41]

https://chromiumcodereview.appspot.com/1408793009/diff/40001/chromecast/brows...
File chromecast/browser/cast_browser_main_parts.cc (left):

https://chromiumcodereview.appspot.com/1408793009/diff/40001/chromecast/brows...
chromecast/browser/cast_browser_main_parts.cc:319: }
Our existing behaviour here is to only provide a BrowserCdmFactory if
kEnableCmaMediaPipeline switch is set.

So, seems like we should apply that same check in
CastContentBrowserClient::CreateCdmFactory?

[xhwang, 2015-11-05 22:54:02]

comments addressed

[xhwang, 2015-11-05 23:06:11]

xhwang@chromium.org changed reviewers:
+ nasko@chromium.org

[xhwang, 2015-11-05 23:06:12]

halliwell: comments addressed. PTAL again.

nasko: Please OWNERS review
    content/public/browser/DEPS
    content/public/browser/content_browser_client.cc
    content/public/browser/content_browser_client.h
I only added one method which already exists in cast_content_browser_client.

https://chromiumcodereview.appspot.com/1408793009/diff/40001/chromecast/brows...
File chromecast/browser/cast_browser_main_parts.cc (left):

https://chromiumcodereview.appspot.com/1408793009/diff/40001/chromecast/brows...
chromecast/browser/cast_browser_main_parts.cc:319: }
On 2015/11/05 22:20:41, halliwell wrote:
> Our existing behaviour here is to only provide a BrowserCdmFactory if
> kEnableCmaMediaPipeline switch is set.
> 
> So, seems like we should apply that same check in
> CastContentBrowserClient::CreateCdmFactory?

oops, I thought about that but then forgot. Thanks for catching it.

Done.

[xhwang, 2015-11-05 23:06:32]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 23:08:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408793009/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408793009/60001

[halliwell, 2015-11-05 23:16:31]

On 2015/11/05 23:08:20, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1408793009/60001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1408793009/60001

chromecast/ lgtm  (I patched the CL into our internal build as well and tested,
all looks good).

[commit-bot: I haz the power, 2015-11-06 01:13:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-06 01:13:41]

Dry run: This issue passed the CQ dry run.

[nasko, 2015-11-06 18:24:29]

content/ LGTM

[xhwang, 2015-11-06 18:26:07]

Description was changed from

==========
media: Remove BrowserCdmFactory inferface.

BrowserCdmFactory interface was introduced as the browser side factory to create
BrowserCdm. Now BrowserCdm has been mreged into MediaKeys interface, this CL
merges BrowserCdmFactory into the more generic CdmFactory interface.

This CL also changes how BrowserCdmFactory is registered/created on Android and
on Cast.

With this CL, we use the same AndroidCdmFactory to create MediaDrmBridge when
it is hosted:
- in the browser process using BrowserCdmManager, or
- in the GPU process using MojoCdmService.

BUG=521731
TEST=Tested MediaDrmBridge creation in the browser and GPU process on Android.
==========

to

==========
media: Remove BrowserCdmFactory inferface.

BrowserCdmFactory interface was introduced as the browser side factory to create
BrowserCdm. Now BrowserCdm has been merged into MediaKeys interface, this CL
merges BrowserCdmFactory into the more generic CdmFactory interface.

This CL also changes how BrowserCdmFactory is registered/created on Android and
on Cast.

With this CL, we use the same AndroidCdmFactory to create MediaDrmBridge when
it is hosted:
- in the browser process using BrowserCdmManager, or
- in the GPU process using MojoCdmService.

BUG=521731
TEST=Tested MediaDrmBridge creation in the browser and GPU process on Android.
==========

[xhwang, 2015-11-06 18:58:28]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2015-11-06 18:58:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
jrummell@chromium.org, halliwell@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1408793009/#ps80001
(title: "Add comment for DEPS change.")

[commit-bot: I haz the power, 2015-11-06 18:59:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408793009/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408793009/80001

[commit-bot: I haz the power, 2015-11-06 21:07:05]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-11-06 21:08:38]

Patchset 4 (id:??) landed as
https://crrev.com/fac3c5e704ff0f2ab04982d372fc70e419a41da0
Cr-Commit-Position: refs/heads/master@{#358390}