Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1905)

Unified Diff: pkg/intl/lib/generate_localized.dart

Issue 140843002: [Intl] Cleanup some code (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: integrate feedback Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/intl/lib/extract_messages.dart ('k') | pkg/intl/lib/intl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/intl/lib/generate_localized.dart
diff --git a/pkg/intl/lib/generate_localized.dart b/pkg/intl/lib/generate_localized.dart
index 0095c8936dd14abfd83c1ab9194f1a1b7cca625e..0dbd4bc8cbd01c5cfabb5439020d894842ceb090 100644
--- a/pkg/intl/lib/generate_localized.dart
+++ b/pkg/intl/lib/generate_localized.dart
@@ -66,10 +66,10 @@ abstract class TranslatedMessage {
* but it can be any identifier that this program and the output of the
* translation can agree on as identifying a message.
*/
- String id;
+ final String id;
/** Our translated version of [originalMessage]. */
- Message translated;
+ final Message translated;
/** The original message that we are a translation of. */
MainMessage originalMessage;
@@ -106,20 +106,21 @@ void generateIndividualMessageFile(String locale,
usableTranslations.sort((a, b) =>
a.originalMessage.name.compareTo(b.originalMessage.name));
for (var translation in usableTranslations) {
- result.write(" ");
- result.write(translation.originalMessage.toCodeForLocale(locale));
- result.write("\n\n");
+ result
+ .write(" ")
+ ..write(translation.originalMessage.toCodeForLocale(locale))
+ ..write("\n\n");
}
result.write("\n final messages = const {\n");
var entries = usableTranslations
.map((translation) => translation.originalMessage.name)
.map((name) => " \"$name\" : $name");
- result.write(entries.join(",\n"));
- result.write("\n };\n}");
+ result
+ ..write(entries.join(",\n"))
+ ..write("\n };\n}");
- var output = new File(path.join(targetDir,
- "${generatedFilePrefix}messages_$locale.dart"));
- output.writeAsStringSync(result.toString());
+ new File(path.join(targetDir,"${generatedFilePrefix}messages_$locale.dart"))
+ ..writeAsStringSync(result.toString());
}
/**
« no previous file with comments | « pkg/intl/lib/extract_messages.dart ('k') | pkg/intl/lib/intl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698