pkg/intl/lib/bidi_formatter.dart - Issue 140843002: [Intl] Cleanup some code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/intl/lib/bidi_formatter.dart

Issue 140843002: [Intl] Cleanup some code (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: integrate feedback Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/intl/lib/bidi_formatter.dart

diff --git a/pkg/intl/lib/bidi_formatter.dart b/pkg/intl/lib/bidi_formatter.dart

index 048a9deb6d2915d974dc9da8c157973c8214ad39..2c3c8c4be4e81c7f17b64b67f3b1ee8993e0ffe4 100644

--- a/pkg/intl/lib/bidi_formatter.dart

+++ b/pkg/intl/lib/bidi_formatter.dart

@@ -172,11 +172,7 @@ class BidiFormatter {

(contextDirection == TextDirection.RTL &&

(direction == TextDirection.LTR ||

Bidi.endsWithLtr(text, isHtml)))) {

- if (contextDirection == TextDirection.LTR) {

- return Bidi.LRM;

- } else {

- return Bidi.RLM;

- }

+ return contextDirection == TextDirection.LTR ? Bidi.LRM : Bidi.RLM;

} else {

return '';

}

« no previous file with comments | « no previous file | pkg/intl/lib/bidi_utils.dart » ('j') | no next file with comments »