[Intl] Cleanup some code

pkg/intl/lib/date_symbols.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 library date_symbols;
 
 /**
  * This holds onto information about how a particular locale formats dates. It
  * contains mostly strings, e.g. what the names of months or weekdays are,
  * but also indicates things like the first day of the week. We expect the data
  * for instances of these to be generated out of ICU or a similar reference
@@ skipping 65 matching lines @@
     AMPMS = map["AMPMS"];
     DATEFORMATS = map["DATEFORMATS"];
     TIMEFORMATS = map["TIMEFORMATS"];
     AVAILABLEFORMATS = map["AVAILABLEFORMATS"];
     FIRSTDAYOFWEEK = map["FIRSTDAYOFWEEK"];
     WEEKENDRANGE = map["WEEKENDRANGE"];
     FIRSTWEEKCUTOFFDAY = map["FIRSTWEEKCUTOFFDAY"];
   }
 
   Map serializeToMap() {
-    var map = new Map();
-    map["NAME"] = NAME;
-    map["ERAS"] = ERAS;
-    map["ERANAMES"] = ERANAMES;
-    map["NARROWMONTHS"] = NARROWMONTHS;
-    map["STANDALONENARROWMONTHS"] = STANDALONENARROWMONTHS;
-    map["MONTHS"] = MONTHS;
-    map["STANDALONEMONTHS"] = STANDALONEMONTHS;
-    map["SHORTMONTHS"] = SHORTMONTHS;
-    map["STANDALONESHORTMONTHS"] = STANDALONESHORTMONTHS;
-    map["WEEKDAYS"] = WEEKDAYS;
-    map["STANDALONEWEEKDAYS"] = STANDALONEWEEKDAYS;
-    map["SHORTWEEKDAYS"] = SHORTWEEKDAYS;
-    map["STANDALONESHORTWEEKDAYS"] = STANDALONESHORTWEEKDAYS;
-    map["NARROWWEEKDAYS"] = NARROWWEEKDAYS;
-    map["STANDALONENARROWWEEKDAYS"] = STANDALONENARROWWEEKDAYS;
-    map["SHORTQUARTERS"] = SHORTQUARTERS;
-    map["QUARTERS"] = QUARTERS;
-    map["AMPMS"] = AMPMS;
-    map["DATEFORMATS"] = DATEFORMATS;
-    map["TIMEFORMATS"] = TIMEFORMATS;
-    map["AVAILABLEFORMATS"] = AVAILABLEFORMATS;
-    map["FIRSTDAYOFWEEK"] = FIRSTDAYOFWEEK;
-    map["WEEKENDRANGE"] = WEEKENDRANGE;
-    map["FIRSTWEEKCUTOFFDAY"] = FIRSTWEEKCUTOFFDAY;
-    return map;
+    return {
+        "NAME": NAME,

[Alan Knight, 2014/01/28 01:33:46]

I think the style guide would indent the map elements only two. Also, at this
point, couldn't this just be a lambda?

[vicb, 2014/01/28 07:52:45]

Indentation fixed.

Not easy to change for a lambda as the method return a map.

[Alan Knight, 2014/01/29 01:27:58]

Why isn't that easy?  foo() => { "hello" : 1, "world" : 2}; is perfectly
allowable syntax.

[vicb, 2014/01/29 08:15:14]

I misunderstood... I was think of replacing the map itself with a closure.
fixed.

+        "ERAS": ERAS,
+        "ERANAMES": ERANAMES,
+        "NARROWMONTHS": NARROWMONTHS,
+        "STANDALONENARROWMONTHS": STANDALONENARROWMONTHS,
+        "MONTHS": MONTHS,
+        "STANDALONEMONTHS": STANDALONEMONTHS,
+        "SHORTMONTHS": SHORTMONTHS,
+        "STANDALONESHORTMONTHS": STANDALONESHORTMONTHS,
+        "WEEKDAYS": WEEKDAYS,
+        "STANDALONEWEEKDAYS": STANDALONEWEEKDAYS,
+        "SHORTWEEKDAYS": SHORTWEEKDAYS,
+        "STANDALONESHORTWEEKDAYS": STANDALONESHORTWEEKDAYS,
+        "NARROWWEEKDAYS": NARROWWEEKDAYS,
+        "STANDALONENARROWWEEKDAYS": STANDALONENARROWWEEKDAYS,
+        "SHORTQUARTERS": SHORTQUARTERS,
+        "QUARTERS": QUARTERS,
+        "AMPMS": AMPMS,
+        "DATEFORMATS": DATEFORMATS,
+        "TIMEFORMATS": TIMEFORMATS,
+        "AVAILABLEFORMATS": AVAILABLEFORMATS,
+        "FIRSTDAYOFWEEK": FIRSTDAYOFWEEK,
+        "WEEKENDRANGE": WEEKENDRANGE,
+        "FIRSTWEEKCUTOFFDAY": FIRSTWEEKCUTOFFDAY
+    };
   }
 
   toString() => NAME;
 }
 
 /**
  * We hard-code the locale data for en_US here so that there's at least one
  * locale always available.
  */
 var en_USSymbols = new DateSymbols(
@@ skipping 72 matching lines @@
   'jmv': 'h:mm a v', // HOUR_MINUTE_GENERIC_TZ
   'jmz': 'h:mm a z', // HOUR_MINUTETZ
   'jz': 'h a z', // HOURGENERIC_TZ
   'm': 'm', // MINUTE
   'ms': 'mm:ss', // MINUTE_SECOND
   's': 's', // SECOND
   'v': 'v', // ABBR_GENERIC_TZ
   'z': 'z', // ABBR_SPECIFIC_TZ
   'zzzz': 'zzzz', // SPECIFIC_TZ
   'ZZZZ': 'ZZZZ'  // ABBR_UTC_TZ
-};
+};