Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 14084004: Use <(SHARED_LIB_DIR) instead of <(PRODUCT_DIR)/lib. (Closed)

Created:
7 years, 8 months ago by tommi (sloooow) - chröme
Modified:
7 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Use <(SHARED_LIB_DIR) instead of <(PRODUCT_DIR)/lib. This is an update on a fix that landed in r193296 and fixed the ASAN builder. The target folder name can be different from one builder to the next, so I'm switching to using the GYP variable instead. BUG=233173 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/chrome_installer.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tommi1
7 years, 8 months ago (2013-04-18 14:46:37 UTC) #1
tommi (sloooow) - chröme
Hey Lei - please take a look (if this is the second email you get, ...
7 years, 8 months ago (2013-04-18 14:48:43 UTC) #2
Lei Zhang
lgtm
7 years, 8 months ago (2013-04-18 20:20:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/14084004/1
7 years, 8 months ago (2013-04-18 20:20:56 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 22:03:26 UTC) #5
Message was sent while issue was closed.
Change committed as 195012

Powered by Google App Engine
This is Rietveld 408576698