QUIC: retransmit packets with the correct encryption.

net/quic/quic_client_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_client_session.h"
 
+#include "base/callback_helpers.h"
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "base/string_number_conversions.h"
 #include "base/values.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
 #include "net/quic/quic_connection_helper.h"
 #include "net/quic/quic_crypto_client_stream_factory.h"
 #include "net/quic/quic_stream_factory.h"
 #include "net/udp/datagram_client_socket.h"
@@ skipping 26 matching lines @@
               server_hostname, config_, this, crypto_config));
 
   connection->set_debug_visitor(&logger_);
   // TODO(rch): pass in full host port proxy pair
   net_log_.BeginEvent(
       NetLog::TYPE_QUIC_SESSION,
       NetLog::StringCallback("host", &server_hostname));
 }
 
 QuicClientSession::~QuicClientSession() {
+  callback_.Reset();

[Ryan Hamilton, 2013/04/26 19:52:17]

I though we were going to run the callback here with some sort of error?

Oh, you did it in CloseSession.  Fair enough.  In that case, I don't think you
need to do this since it'll be cleared when the session is deleted.

That being said, you could add a DCHECK(callback_.is_null());

[ramant (doing other things), 2013/04/30 02:17:03]

Ran the callback_ if it is not NULL with error.

Done.

[Ryan Hamilton, 2013/04/30 02:56:14]

I'm not sure I follow.  Is the callback suposed to be set here?  if not, let's
DCHECK().  if so, under what circumstances would it be set?

[ramant (doing other things), 2013/04/30 19:00:32]

Changed the QuicClientSessionTest's GoAwayReceived to CompleteCryptoHandshake
before calling OnGoAway.

Added DCHECK.
Done.

   connection()->set_debug_visitor(NULL);
   net_log_.EndEvent(NetLog::TYPE_QUIC_SESSION);
 }
 
 QuicReliableClientStream* QuicClientSession::CreateOutgoingReliableStream() {
-  if (!crypto_stream_->handshake_complete()) {
-    DLOG(INFO) << "Crypto handshake not complete, no outgoing stream created.";
+  if (!crypto_stream_->encryption_established()) {
+    DLOG(INFO) << "Encryption not active so no outgoing stream created.";
     return NULL;
   }
   if (GetNumOpenStreams() >= get_max_open_streams()) {
     DLOG(INFO) << "Failed to create a new outgoing stream. "
                << "Already " << GetNumOpenStreams() << " open.";
     return NULL;
   }
   if (goaway_received()) {
     DLOG(INFO) << "Failed to create a new outgoing stream. "
                << "Already received goaway.";
@@ skipping 10 matching lines @@
   return crypto_stream_.get();
 };
 
 int QuicClientSession::CryptoConnect(const CompletionCallback& callback) {
   if (!crypto_stream_->CryptoConnect()) {
     // TODO(wtc): change crypto_stream_.CryptoConnect() to return a
     // QuicErrorCode and map it to a net error code.
     return ERR_CONNECTION_FAILED;
   }
 
-  if (IsCryptoHandshakeComplete()) {
+  if (IsCryptoHandshakeConfirmed()) {
     return OK;
   }
 
   callback_ = callback;
   return ERR_IO_PENDING;
 }
 
 ReliableQuicStream* QuicClientSession::CreateIncomingReliableStream(
     QuicStreamId id) {
   DLOG(ERROR) << "Server push not supported";
   return NULL;
 }
 
 void QuicClientSession::CloseStream(QuicStreamId stream_id) {
   QuicSession::CloseStream(stream_id);
 
   if (GetNumOpenStreams() == 0) {
     stream_factory_->OnIdleSession(this);
   }
 }
 
-void QuicClientSession::OnCryptoHandshakeComplete(QuicErrorCode error) {
+void QuicClientSession::OnCryptoHandshakeEvent(CryptoHandshakeEvent event) {
   if (!callback_.is_null()) {
-    callback_.Run(error == QUIC_NO_ERROR ? OK : ERR_UNEXPECTED);
+    // TODO(rtenneti): Currently for all CryptoHandshakeEvent events, callback_
+    // could send the data. Change the following code if that changes.
+    base::ResetAndReturn(&callback_).Run(OK);
   }
 }
 
 void QuicClientSession::StartReading() {
   if (read_pending_) {
     return;
   }
   read_pending_ = true;
   int rv = socket_->Read(read_buffer_, read_buffer_->size(),
                          base::Bind(&QuicClientSession::OnReadComplete,
                                     weak_factory_.GetWeakPtr()));
   if (rv == ERR_IO_PENDING) {
     return;
   }
 
   // Data was read, process it.
   // Schedule the work through the message loop to avoid recursive
   // callbacks.
   MessageLoop::current()->PostTask(
       FROM_HERE,
       base::Bind(&QuicClientSession::OnReadComplete,
                  weak_factory_.GetWeakPtr(), rv));
 }
 
 void QuicClientSession::CloseSessionOnError(int error) {

[Ryan Hamilton, 2013/04/26 19:52:17]

I think you also want to override QuicSession::ConnectionClose() to invoke the
callback.  What do you think?

[ramant (doing other things), 2013/04/30 02:17:03]

Done.

+  if (!callback_.is_null()) {
+    base::ResetAndReturn(&callback_).Run(error);
+  }
   while (!streams()->empty()) {
     ReliableQuicStream* stream = streams()->begin()->second;
     QuicStreamId id = stream->id();
     static_cast<QuicReliableClientStream*>(stream)->OnError(error);
     CloseStream(id);
   }
   net_log_.BeginEvent(
       NetLog::TYPE_QUIC_SESSION,
       NetLog::IntegerCallback("net_error", error));
   // Will delete |this|.
@@ skipping 26 matching lines @@
     connection()->ProcessUdpPacket(local_address, peer_address, packet);
     if (!connection()->connected()) {
       stream_factory_->OnSessionClose(this);
       return;
     }
     StartReading();
   }
 }
 
 }  // namespace net