Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: media/base/audio_converter.cc

Issue 14083011: CHECK for adding duplicate converter inputs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_converter.cc
diff --git a/media/base/audio_converter.cc b/media/base/audio_converter.cc
index ec74e038a3bc7f4ded3073095fb259d451ec8237..151d88d781aa59e39dc0066d2b77cc02b39241f9 100644
--- a/media/base/audio_converter.cc
+++ b/media/base/audio_converter.cc
@@ -88,6 +88,10 @@ AudioConverter::AudioConverter(const AudioParameters& input_params,
AudioConverter::~AudioConverter() {}
void AudioConverter::AddInput(InputCallback* input) {
+ // TODO(dalecurtis): Speculative CHECK for http://crbug.com/233026, should be
+ // converted to a DCHECK once resolved.
+ CHECK(std::find(transform_inputs_.begin(), transform_inputs_.end(), input) ==
+ transform_inputs_.end());
transform_inputs_.push_back(input);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698