Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 14083011: CHECK for adding duplicate converter inputs. (Closed)

Created:
7 years, 8 months ago by DaleCurtis
Modified:
7 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

CHECK for adding duplicate converter inputs. CHECK to see if we're getting into weird states due to inputs being added twice. BUG=233026 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196271

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M media/base/audio_converter.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
DaleCurtis
7 years, 8 months ago (2013-04-24 22:04:11 UTC) #1
scherkus (not reviewing)
lgtm w/ nit https://codereview.chromium.org/14083011/diff/1/media/base/audio_converter.cc File media/base/audio_converter.cc (right): https://codereview.chromium.org/14083011/diff/1/media/base/audio_converter.cc#newcode91 media/base/audio_converter.cc:91: CHECK(std::find(transform_inputs_.begin(), transform_inputs_.end(), input) == if this ...
7 years, 8 months ago (2013-04-24 22:06:41 UTC) #2
DaleCurtis
https://codereview.chromium.org/14083011/diff/1/media/base/audio_converter.cc File media/base/audio_converter.cc (right): https://codereview.chromium.org/14083011/diff/1/media/base/audio_converter.cc#newcode91 media/base/audio_converter.cc:91: CHECK(std::find(transform_inputs_.begin(), transform_inputs_.end(), input) == On 2013/04/24 22:06:42, scherkus wrote: ...
7 years, 8 months ago (2013-04-24 22:13:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/14083011/5001
7 years, 8 months ago (2013-04-24 22:14:13 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-25 00:24:51 UTC) #5
Message was sent while issue was closed.
Change committed as 196271

Powered by Google App Engine
This is Rietveld 408576698