Remove ENABLE_CUSTOM_ELEMENTS compile time flag

Remove ENABLE_CUSTOM_ELEMENTS compile time flag

CUSTOM_ELEMENTS is enabled by default on Chromium. This patch removes the necessary #ifdefs from Blink.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149070

[riju_, 2013-04-19 12:22:23]

Remove ENABLE_CUSTOM_ELEMENTS compile time flag as part of clean up activity for
Blink.

[haraken, 2013-04-19 12:40:36]

cc-ing web components experts

[dglazkov, 2013-04-19 16:32:07]

lgtm.

[commit-bot: I haz the power, 2013-04-19 16:32:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/14083009/2001

[commit-bot: I haz the power, 2013-04-19 16:50:21]

Retried try job too often on linux_layout_rel for step(s) test_shell_tests,
webkit_lint, webkit_tests, webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[dglazkov, 2013-04-19 16:55:25]

https://chromiumcodereview.appspot.com/14083009/diff/2001/Source/bindings/scr...
File Source/bindings/scripts/CodeGeneratorV8.pm (right):

https://chromiumcodereview.appspot.com/14083009/diff/2001/Source/bindings/scr...
Source/bindings/scripts/CodeGeneratorV8.pm:1310:
AddToImplIncludes("CustomElementRegistry.h", "CUSTOM_ELEMENTS");
This guy needs tweaking, too.

[riju_, 2013-04-22 14:12:24]

On 2013/04/19 16:55:25, Dimitri Glazkov wrote:
>
https://chromiumcodereview.appspot.com/14083009/diff/2001/Source/bindings/scr...
> File Source/bindings/scripts/CodeGeneratorV8.pm (right):
> 
>
https://chromiumcodereview.appspot.com/14083009/diff/2001/Source/bindings/scr...
> Source/bindings/scripts/CodeGeneratorV8.pm:1310:
> AddToImplIncludes("CustomElementRegistry.h", "CUSTOM_ELEMENTS");
> This guy needs tweaking, too.

Hi, can somebody please try the bots again ?

[commit-bot: I haz the power, 2013-04-22 14:21:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/14083009/1...

[commit-bot: I haz the power, 2013-04-22 14:21:48]

Failed to apply patch for Source/core/dom/Document.idl:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/Document.idl
  Hunk #1 FAILED at 279.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/dom/Document.idl.rej

Patch:       Source/core/dom/Document.idl
Index: Source/core/dom/Document.idl
diff --git a/Source/core/dom/Document.idl b/Source/core/dom/Document.idl
index
d591f5dfe9b9d6a4704a1635c3e7aff29eb33986..f0baf2312952752fc29f80e54a322330572bc2d6
100644
--- a/Source/core/dom/Document.idl
+++ b/Source/core/dom/Document.idl
@@ -279,12 +279,10 @@
     [ReturnNewObject, EnabledAtRuntime=touch, Custom, RaisesException]
TouchList createTouchList();
 #endif
 
-#if defined(ENABLE_CUSTOM_ELEMENTS) && ENABLE_CUSTOM_ELEMENTS
-    [EnabledAtRuntime=customDOMElements, Conditional=CUSTOM_ELEMENTS,
ImplementedAs=registerElement, CallWith=ScriptState,
DeliverCustomElementCallbacks, RaisesException] CustomElementConstructor
webkitRegister(DOMString name, optional Dictionary options);
+    [EnabledAtRuntime=customDOMElements, ImplementedAs=registerElement,
CallWith=ScriptState, DeliverCustomElementCallbacks, RaisesException]
CustomElementConstructor webkitRegister(DOMString name, optional Dictionary
options);
     [ReturnNewObject, DeliverCustomElementCallbacks, PerWorldBindings,
RaisesException] Element createElement(DOMString localName,
[TreatNullAs=NullString] DOMString typeExtension);
     [ReturnNewObject, DeliverCustomElementCallbacks, RaisesException] Element
createElementNS([TreatNullAs=NullString] DOMString namespaceURI, DOMString
qualifiedName,
                             [TreatNullAs=NullString] DOMString typeExtension);
-#endif
 
     // Page visibility API.
     readonly attribute DOMString webkitVisibilityState;

[riju_, 2013-04-23 09:01:33]

On 2013/04/22 14:21:48, I haz the power (commit-bot) wrote:
> Failed to apply patch for Source/core/dom/Document.idl:
> While running patch -p1 --forward --force --no-backup-if-mismatch;
>   patching file Source/core/dom/Document.idl
>   Hunk #1 FAILED at 279.
>   1 out of 1 hunk FAILED -- saving rejects to file
> Source/core/dom/Document.idl.rej
> 
> Patch:       Source/core/dom/Document.idl
> Index: Source/core/dom/Document.idl
> diff --git a/Source/core/dom/Document.idl b/Source/core/dom/Document.idl
> index
>
d591f5dfe9b9d6a4704a1635c3e7aff29eb33986..f0baf2312952752fc29f80e54a322330572bc2d6
> 100644
> --- a/Source/core/dom/Document.idl
> +++ b/Source/core/dom/Document.idl
> @@ -279,12 +279,10 @@
>      [ReturnNewObject, EnabledAtRuntime=touch, Custom, RaisesException]
> TouchList createTouchList();
>  #endif
>  
> -#if defined(ENABLE_CUSTOM_ELEMENTS) && ENABLE_CUSTOM_ELEMENTS
> -    [EnabledAtRuntime=customDOMElements, Conditional=CUSTOM_ELEMENTS,
> ImplementedAs=registerElement, CallWith=ScriptState,
> DeliverCustomElementCallbacks, RaisesException] CustomElementConstructor
> webkitRegister(DOMString name, optional Dictionary options);
> +    [EnabledAtRuntime=customDOMElements, ImplementedAs=registerElement,
> CallWith=ScriptState, DeliverCustomElementCallbacks, RaisesException]
> CustomElementConstructor webkitRegister(DOMString name, optional Dictionary
> options);
>      [ReturnNewObject, DeliverCustomElementCallbacks, PerWorldBindings,
> RaisesException] Element createElement(DOMString localName,
> [TreatNullAs=NullString] DOMString typeExtension);
>      [ReturnNewObject, DeliverCustomElementCallbacks, RaisesException] Element
> createElementNS([TreatNullAs=NullString] DOMString namespaceURI, DOMString
> qualifiedName,
>                              [TreatNullAs=NullString] DOMString
typeExtension);
> -#endif
>  
>      // Page visibility API.
>      readonly attribute DOMString webkitVisibilityState;

The patch now applies locally on my machine .. lets try the try bots once again
?

[riju_, 2013-04-24 15:06:04]

rebased . can we try the try bot once again ?

[commit-bot: I haz the power, 2013-04-24 17:34:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/14083009/3...

[commit-bot: I haz the power, 2013-04-24 17:34:15]

Failed to apply patch for Source/core/scripts/make_names.pl:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/scripts/make_names.pl
  Hunk #1 succeeded at 843 (offset -15 lines).
  Hunk #2 FAILED at 917.
  Hunk #3 succeeded at 906 (offset -19 lines).
  Hunk #4 succeeded at 1111 with fuzz 1 (offset -81 lines).
  Hunk #5 FAILED at 1267.
  2 out of 5 hunks FAILED -- saving rejects to file
Source/core/scripts/make_names.pl.rej

Patch:       Source/core/scripts/make_names.pl
Index: Source/core/scripts/make_names.pl
diff --git a/Source/core/scripts/make_names.pl
b/Source/core/scripts/make_names.pl
index
06650963ba5cbba990d7ecb18b5bcea1f0ccc3dd..9c466dbeedbb2d18486c3b73d7cdfa530f712a76
100755
--- a/Source/core/scripts/make_names.pl
+++ b/Source/core/scripts/make_names.pl
@@ -858,10 +858,8 @@ print F <<END
 #include "RuntimeEnabledFeatures.h"
 #include "Settings.h"
 
-#if ENABLE(CUSTOM_ELEMENTS)
 #include "CustomElementConstructor.h"
 #include "CustomElementRegistry.h"
-#endif
 
 namespace WebCore {
 
@@ -919,7 +917,6 @@ END
 ;
 
 print F <<END
-#if ENABLE(CUSTOM_ELEMENTS)
     if (document->registry()) {
         if (RefPtr<CustomElementConstructor> constructor =
document->registry()->find(nullQName(), qName)) {
             RefPtr<Element> element = constructor->createElement();
@@ -927,7 +924,6 @@ print F <<END
             return
static_pointer_cast<$parameters{namespace}Element>(element.release());
         }
     }
-#endif
 
     if (!gFunctionMap)
         createFunctionMap();
@@ -1195,9 +1191,7 @@ END
         print F <<END
 #include "V8$parameters{namespace}Element.h"
 
-#if ENABLE(CUSTOM_ELEMENTS)
 #include "CustomElementHelpers.h"
-#endif
 
 #include <v8.h>
 END
@@ -1272,10 +1266,8 @@ END
 ;
     if ($wrapperFactoryType eq "V8") {
         print F <<END
-#if ENABLE(CUSTOM_ELEMENTS)
     if (PassRefPtr<CustomElementConstructor> constructor =
CustomElementHelpers::constructorOf(element))
         return CustomElementHelpers::wrap(element, creationContext,
constructor, isolate);
-#endif
 END
 ;
     }

[dominicc (has gone to gerrit), 2013-04-25 00:56:49]

I would like to land this for you, but it looks like Riju has not signed a
Contributor License Agreement. Search this page
<http://dev.chromium.org/developers/contributing-code> for "Legal" for the
necessary steps to take.

[mal, 2013-04-25 01:46:09]

rijubrata.bhaumik@intel.com is listed as an authorized contributed by Intel. The
CLA has been signed.

[mal, 2013-04-25 01:49:02]

On 2013/04/25 01:46:09, mal wrote:
> mailto:rijubrata.bhaumik@intel.com is listed as an authorized contributed by
Intel. The
> CLA has been signed.

s/contributed/contributor/g

[dominicc (has gone to gerrit), 2013-04-25 03:59:36]

Committed patchset #6 manually as r149070 (presubmit successful).