Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: content/browser/media/cdm/browser_cdm_manager.h

Issue 1407933010: media: Make MediaKeys ref-counted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase only Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/cdm/browser_cdm_manager.h
diff --git a/content/browser/media/cdm/browser_cdm_manager.h b/content/browser/media/cdm/browser_cdm_manager.h
index 857cdd1d2022d45abc3d128646ae186077e2d524..fd2168d35f64bd127c7bbbcd51a98c3ff66569c6 100644
--- a/content/browser/media/cdm/browser_cdm_manager.h
+++ b/content/browser/media/cdm/browser_cdm_manager.h
@@ -11,7 +11,6 @@
#include "base/basictypes.h"
#include "base/callback.h"
-#include "base/containers/scoped_ptr_hash_map.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "content/common/content_export.h"
@@ -20,7 +19,6 @@
#include "content/public/browser/browser_message_filter.h"
#include "content/public/common/permission_status.mojom.h"
#include "ipc/ipc_message.h"
-#include "media/base/browser_cdm.h"
#include "media/base/cdm_promise.h"
#include "media/base/eme_constants.h"
#include "media/base/media_keys.h"
@@ -52,7 +50,9 @@ class CONTENT_EXPORT BrowserCdmManager : public BrowserMessageFilter {
const IPC::Message& message) override;
bool OnMessageReceived(const IPC::Message& message) override;
- media::BrowserCdm* GetCdm(int render_frame_id, int cdm_id) const;
+ // Returns the CDM associated with |render_frame_id| and |cdm_id|. Returns
+ // null if no such CDM exists.
+ scoped_refptr<media::MediaKeys> GetCdm(int render_frame_id, int cdm_id) const;
// Notifies that the render frame has been deleted so that all CDMs belongs
// to this render frame needs to be destroyed as well. This is needed because
@@ -196,8 +196,8 @@ class CONTENT_EXPORT BrowserCdmManager : public BrowserMessageFilter {
// The key in the following maps is a combination of |render_frame_id| and
// |cdm_id|.
- // Map of managed BrowserCdms.
- typedef base::ScopedPtrHashMap<uint64, media::ScopedBrowserCdmPtr> CdmMap;
+ // Map of managed CDMs.
+ typedef std::map<uint64, scoped_refptr<media::MediaKeys>> CdmMap;
CdmMap cdm_map_;
// Map of CDM's security origin.
« no previous file with comments | « content/browser/media/android/media_drm_credential_manager.cc ('k') | content/browser/media/cdm/browser_cdm_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698