src/IceCfg.cpp - Issue 1407063002: Subzero. Misc ARM32 bugfixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCfg.cpp

Issue 1407063002: Subzero. Misc ARM32 bugfixes. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceCfg.cpp

diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp

index 4c58d50490c033da495149a457b157cb8c50d164..a1c4b5f7e17774b706c6cb40350fbab18dcadf06 100644

--- a/src/IceCfg.cpp

+++ b/src/IceCfg.cpp

@@ -682,7 +682,7 @@ void Cfg::emitTextHeader(const IceString &MangledName, GlobalContext *Ctx,

Ostream &Str = Ctx->getStrEmit();

Str << "\t.text\n";

if (Ctx->getFlags().getFunctionSections())

- Str << "\t.section\t.text." << MangledName << ",\"ax\",@progbits\n";

+ Str << "\t.section\t.text." << MangledName << ",\"ax\",%progbits\n";

Jim Stichnoth 2015/10/15 23:34:21 Just checking -- is this syntax also valid for x86

John 2015/11/05 20:25:13 well, szbuild_spec2k.py --target=x8632 --filetype=

if (!Asm->getInternal() || Ctx->getFlags().getDisableInternal()) {

Str << "\t.globl\t" << MangledName << "\n";

Str << "\t.type\t" << MangledName << ",%function\n";