Issue 14069017: Move *UserLoggedIn methods from UserManager to UserManagerImpl

Issue 14069017: Move *UserLoggedIn methods from UserManager to UserManagerImpl (Closed)

Created:
7 years, 8 months ago by bartfab (slow)

Modified:
7 years, 8 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Denis Kuznetsov (DE-MUC)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move *UserLoggedIn methods from UserManager to UserManagerImpl This CL trims down the UserManager interfaces by moving the *UserLogged methods that are really just implementation details to UserManagerImpl. BUG=None TEST=Manual and browser/unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194938

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit addressed. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -216 lines)			Patch
M	chrome/browser/chromeos/login/existing_user_controller.cc	View		3 chunks	+13 lines, -20 lines	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller_browsertest.cc	View		2 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/mock_user_manager.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager.h	View		1 chunk	+0 lines, -22 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.h	View	1	2 chunks	+21 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.cc	View		2 chunks	+125 lines, -125 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.cc	View		3 chunks	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bartfab (slow)

Hi Nikita, Could you take a look? As you can see, the bots all liked ...

7 years, 8 months ago (2013-04-18 11:13:26 UTC) #1

Nikita (slow)

lgtm https://codereview.chromium.org/14069017/diff/1/chrome/browser/chromeos/login/user_manager_impl.h File chrome/browser/chromeos/login/user_manager_impl.h (right): https://codereview.chromium.org/14069017/diff/1/chrome/browser/chromeos/login/user_manager_impl.h#newcode167 chrome/browser/chromeos/login/user_manager_impl.h:167: // Indicates that user just started incognito session. ...

7 years, 8 months ago (2013-04-18 12:13:51 UTC) #2

bartfab (slow)

https://codereview.chromium.org/14069017/diff/1/chrome/browser/chromeos/login/user_manager_impl.h File chrome/browser/chromeos/login/user_manager_impl.h (right): https://codereview.chromium.org/14069017/diff/1/chrome/browser/chromeos/login/user_manager_impl.h#newcode167 chrome/browser/chromeos/login/user_manager_impl.h:167: // Indicates that user just started incognito session. On ...

7 years, 8 months ago (2013-04-18 13:03:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/14069017/8001

7 years, 8 months ago (2013-04-18 13:03:21 UTC) #4

Message was sent while issue was closed.

Change committed as 194938

Expand Messages | Collapse Messages