Issue 14066022: Use the last committed entry in DidStopLoading, not the pending entry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14066022: Use the last committed entry in DidStopLoading, not the pending entry. (Closed)

Created:
7 years, 8 months ago by Charlie Reis

Modified:
7 years, 8 months ago

Reviewers:
brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Use the last committed entry in DidStopLoading, not the pending entry. BUG=233053 TEST=WebContentsImplBrowserTest.DidStopLoadingDetailsWithPending Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195293

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+129 lines, -1 line)			Patch
M	content/browser/web_contents/web_contents_impl.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
A	content/browser/web_contents/web_contents_impl_browsertest.cc	View	1 chunk	+124 lines, -0 lines	0 comments	Download
M	content/content_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Charlie Reis

Brett, can you take a look? This was causing issues with my fix for http://crbug.com/9682, ...

7 years, 8 months ago (2013-04-18 15:02:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/14066022/1

7 years, 8 months ago (2013-04-19 18:18:05 UTC) #3

Message was sent while issue was closed.

Change committed as 195293