crosstest/test_icmp.h - Issue 1406593003: Optimize 64-bit compares with zero

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crosstest/test_icmp.h

Issue 1406593003: Optimize 64-bit compares with zero (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Add test for lowering cases, cover 32-bit as well. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: crosstest/test_icmp.h

diff --git a/crosstest/test_icmp.h b/crosstest/test_icmp.h

index e1ea4958a26de8d03dfdbf26e813a0ab5dfff21d..ebeff44d291548506a77ddf0f63022d427c7fc19 100644

--- a/crosstest/test_icmp.h

+++ b/crosstest/test_icmp.h

@@ -24,7 +24,11 @@

bool icmp##cmp(uint64 a, uint64 b); \

v4ui32 icmp##cmp(v4ui32 a, v4ui32 b); \

v8ui16 icmp##cmp(v8ui16 a, v8ui16 b); \

- v16ui8 icmp##cmp(v16ui8 a, v16ui8 b);

+ v16ui8 icmp##cmp(v16ui8 a, v16ui8 b); \

+ bool icmp_zero##cmp(uint8_t a); \

+ bool icmp_zero##cmp(uint16_t a); \

+ bool icmp_zero##cmp(uint32_t a); \

+ bool icmp_zero##cmp(uint64 a);

ICMP_U_TABLE

#undef X

@@ -35,7 +39,11 @@ ICMP_U_TABLE

bool icmp##cmp(int64 a, int64 b); \

v4si32 icmp##cmp(v4si32 a, v4si32 b); \

v8si16 icmp##cmp(v8si16 a, v8si16 b); \

- v16si8 icmp##cmp(v16si8 a, v16si8 b);

+ v16si8 icmp##cmp(v16si8 a, v16si8 b); \

+ bool icmp_zero##cmp(myint8_t a); \

+ bool icmp_zero##cmp(int16_t a); \

+ bool icmp_zero##cmp(int32_t a); \

+ bool icmp_zero##cmp(int64 a);

ICMP_S_TABLE

#undef X

« no previous file with comments | « no previous file | crosstest/test_icmp.cpp » ('j') | src/IceTargetLoweringX86BaseImpl.h » ('J')