Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1665)

Unified Diff: skia/skia.gyp

Issue 14065005: Introduce arm_version to allow building for armv5, v6 or v7. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | third_party/libwebp/libwebp.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/skia.gyp
diff --git a/skia/skia.gyp b/skia/skia.gyp
index 2af2377863b0f6c879c3eb3f188787cc918cefe0..011e34d0f8d937c164df4dd79af704f119cd0568 100644
--- a/skia/skia.gyp
+++ b/skia/skia.gyp
@@ -343,12 +343,7 @@
[ 'OS != "win"', {
'sources/': [ ['exclude', '_win\\.(cc|cpp)$'] ],
}],
- [ 'armv7 == 1', {
- 'defines': [
- '__ARM_ARCH__=7',
- ],
- }],
- [ 'armv7 == 1 and arm_neon == 1', {
+ [ 'target_arch == "arm" and arm_version >= 7 and arm_neon == 1', {
'defines': [
'__ARM_HAVE_NEON',
],
@@ -674,12 +669,7 @@
}],
[ 'target_arch == "arm"', {
'conditions': [
- [ 'armv7 == 1', {
- 'defines': [
- '__ARM_ARCH__=7',
- ],
- }],
- [ 'armv7 == 1 and arm_neon == 1', {
+ [ 'arm_version >= 7 and arm_neon == 1', {
'defines': [
'__ARM_HAVE_NEON',
],
@@ -708,12 +698,12 @@
'../third_party/skia/src/opts/SkBitmapProcState_opts_arm.cpp',
],
}],
- [ 'armv7 == 1 and arm_neon == 0', {
+ [ 'target_arch == "arm" and (arm_version < 7 or arm_neon == 0)', {
'sources': [
'../third_party/skia/src/opts/memset.arm.S',
],
}],
- [ 'armv7 == 1 and arm_neon == 1', {
+ [ 'target_arch == "arm" and arm_version >= 7 and arm_neon == 1', {
'sources': [
'../third_party/skia/src/opts/memset16_neon.S',
'../third_party/skia/src/opts/memset32_neon.S',
@@ -724,13 +714,13 @@
'../third_party/skia/src/opts/SkBlitRow_opts_arm_neon.cpp',
],
}],
- [ 'target_arch == "arm" and armv7 == 0', {
+ [ 'target_arch == "arm" and arm_version < 6', {
'sources': [
'../third_party/skia/src/opts/SkBlitRow_opts_none.cpp',
'../third_party/skia/src/opts/SkUtils_opts_none.cpp',
],
}],
- [ 'target_arch == "arm" and armv7 == 1', {
+ [ 'target_arch == "arm" and arm_version >= 6', {
'sources': [
'../third_party/skia/src/opts/SkBlitRow_opts_arm.cpp',
'../third_party/skia/src/opts/SkBlitRow_opts_arm.h',
« no previous file with comments | « build/common.gypi ('k') | third_party/libwebp/libwebp.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698